Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] when model_or_parameter is not nn.Module instance. #283

Merged
merged 6 commits into from
Oct 24, 2024

Conversation

kozistr
Copy link
Owner

@kozistr kozistr commented Oct 24, 2024

Problem (Why?)

related to #282

Solution (What/How?)

  • refactor/update/fix get_optimizer_parameters

Other changes (bug fixes, small refactors)

N/A

Notes

N/A

@kozistr kozistr added bug Something isn't working documentation Improvements or additions to documentation refactoring Refactoring labels Oct 24, 2024
@kozistr kozistr self-assigned this Oct 24, 2024
@kozistr kozistr changed the title [Fix] when model_or_parameter is not a nn.Module instance. [Fix] when model_or_parameter is not nn.Module instance. Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (20ed84f) to head (23adc86).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #283   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           94        94           
  Lines         7241      7248    +7     
=========================================
+ Hits          7241      7248    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozistr kozistr merged commit ed1d3e1 into main Oct 24, 2024
4 checks passed
@kozistr kozistr deleted the refactor/get-model-parameters branch October 24, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation refactoring Refactoring size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant