Skip to content

Commit

Permalink
ssh kitten: Fix non-standard properties in terminfo such as the ones …
Browse files Browse the repository at this point in the history
…used for true color not being copied
  • Loading branch information
kovidgoyal committed Jun 12, 2021
1 parent 7a44765 commit 962acd1
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions docs/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ To update |kitty|, :doc:`follow the instructions <binary>`.
- Remote control: Allow matching tabs by index number in currently active OS
Window (:iss:`3708`)

- ssh kitten: Fix non-standard properties in terminfo such as the ones used for
true color not being copied (:iss:`312`)


0.20.3 [2021-05-06]
----------------------
Expand Down
2 changes: 1 addition & 1 deletion docs/faq.rst
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ server, use the following one-liner instead (it
is slower as it needs to ssh into the server twice, but will work with most
servers)::

infocmp xterm-kitty | ssh myserver tic -x -o \~/.terminfo /dev/stdin
infocmp -a xterm-kitty | ssh myserver tic -x -o \~/.terminfo /dev/stdin

If you are behind a proxy (like Balabit) that prevents this, you must redirect the
1st command to a file, copy that to the server and run ``tic`` manually. If you
Expand Down
2 changes: 1 addition & 1 deletion kittens/ssh/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ def main(args: List[str]) -> NoReturn:
else:
hostname, remote_args = server_args[0], server_args[1:]
cmd += ['-t', hostname]
terminfo = subprocess.check_output(['infocmp']).decode('utf-8')
terminfo = subprocess.check_output(['infocmp', '-a']).decode('utf-8')
f = get_posix_cmd if use_posix else get_python_cmd
cmd += f(terminfo, remote_args)
os.execvp('ssh', cmd)
Expand Down

0 comments on commit 962acd1

Please sign in to comment.