Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Friend App #725

Closed
wants to merge 6 commits into from
Closed

Add Friend App #725

wants to merge 6 commits into from

Conversation

D1telo
Copy link

@D1telo D1telo commented Sep 30, 2022

Friend App

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

@OleksiyRudenko
Copy link
Member

This won't work
image

@OleksiyRudenko
Copy link
Member

Also submission for Building a Tiny JS World is missing

@OleksiyRudenko
Copy link
Member

What #723 has to do with this PR?

@D1telo
Copy link
Author

D1telo commented Oct 3, 2022

Also submission for Building a Tiny JS World is missing

Sorry I just thought that was enough. I created a new pr

@D1telo
Copy link
Author

D1telo commented Oct 3, 2022

What #723 has to do with this PR?

this just T9 ,sry i`m fixed it ,and add full files with friends app

@OleksiyRudenko
Copy link
Member

OleksiyRudenko commented Oct 5, 2022

You added files needed for review. But there is still a submodule that is not required and will also pollute a shared repository.
Please remove.

image

@D1telo D1telo closed this Oct 6, 2022
@D1telo D1telo deleted the task-friends-app branch October 6, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants