Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update application-api references #1174

Merged
merged 6 commits into from
Jun 6, 2024

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented May 17, 2024

Description

The PR updates all references to application-api using the new organization konflux-ci instead of redhat-appstudio.

It also removes any mentions to DeploymentTarget as it was removed here

Issue ticket number and link

https://issues.redhat.com/browse/DEVHAS-656

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

Copy link

openshift-ci bot commented May 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@thepetk thepetk marked this pull request as ready for review May 27, 2024 20:42
@openshift-ci openshift-ci bot requested review from jkopriva and johnbieren May 27, 2024 20:42
@thepetk thepetk force-pushed the ft/update_application_api_refs branch from 922487d to 7af787c Compare May 27, 2024 20:49
@thepetk thepetk changed the title Update application-api references refactor: Update application-api references May 27, 2024
@thepetk
Copy link
Contributor Author

thepetk commented May 27, 2024

The PR checks are now failing because konflux-ci/application-api#83 needs to be merged.

@thepetk
Copy link
Contributor Author

thepetk commented May 27, 2024

/retest

johnbieren
johnbieren previously approved these changes May 28, 2024
@johnbieren johnbieren dismissed their stale review May 28, 2024 12:04

failing ci, code changes lgtm though

@thepetk
Copy link
Contributor Author

thepetk commented May 28, 2024

@johnbieren yes, I think redhat-appstudio/application-service#476 needs to be merged first. Added WIP prefix.

@thepetk thepetk changed the title refactor: Update application-api references WIP: refactor: Update application-api references May 28, 2024
@thepetk thepetk force-pushed the ft/update_application_api_refs branch from 7ca0b5a to 77c061a Compare May 29, 2024 20:57
@github-actions github-actions bot added 5-10 min and removed 1-5 min labels May 29, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@thepetk thepetk force-pushed the ft/update_application_api_refs branch from 1e09504 to a15d7f0 Compare May 31, 2024 11:44
@github-actions github-actions bot added 1-5 min and removed 5-10 min labels May 31, 2024
@thepetk thepetk force-pushed the ft/update_application_api_refs branch from a15d7f0 to d908955 Compare June 3, 2024 11:40
@thepetk
Copy link
Contributor Author

thepetk commented Jun 5, 2024

@dheerajodha I had to rebase my PR. I've just pushed the updated version. Could you please review once more? Thanks!

@dheerajodha
Copy link
Member

@thepetk Sure, I'm seeing some conflicts with the go.sum file, would that need to be fixed beforehand?
If not, I'll add the lgtm label. Wdyt?

@thepetk
Copy link
Contributor Author

thepetk commented Jun 5, 2024

@thepetk Sure, I'm seeing some conflicts with the go.sum file, would that need to be fixed beforehand? If not, I'll add the lgtm label. Wdyt?

Done! I have lost the count on the times I rebased :D Thanks for the help!

@dheerajodha
Copy link
Member

/test redhat-appstudio-e2e
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 5, 2024
@thepetk thepetk force-pushed the ft/update_application_api_refs branch from 78f488a to f63ee2f Compare June 5, 2024 22:44
@openshift-ci openshift-ci bot removed the lgtm label Jun 5, 2024
@thepetk
Copy link
Contributor Author

thepetk commented Jun 5, 2024

@dheerajodha I've rebased once more, I feel the faster we merge it the better :D

@dheerajodha
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 6, 2024
@dheerajodha dheerajodha merged commit 478d9cd into konflux-ci:main Jun 6, 2024
10 checks passed
@dheerajodha
Copy link
Member

@dheerajodha I've rebased once more, I feel the faster we merge it the better :D

Ah sorry about that, idky it gave you this rebase hell, this doesn't usually happen :D but merged it finally 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants