Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): add iOS client and fix video download issue #351

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

ruizlenato
Copy link
Contributor

Description

  • Introduced a new iOS client configuration (IOSClient) with device model, user agent, and updated version key.
  • Updated innertubeClient and clientInfo to include deviceModel for better compatibility.
  • Changed the default client from AndroidClient to IOSClient.
  • Commented out playerParams in the video data request, addressing video download issues.
  • Minor code cleanup to improve readability.

Issues to fix

Please link issues this PR will fix:
#348

- Introduced a new iOS client configuration (`IOSClient`) with device
model, user agent, and updated version key.
- Updated `innertubeClient` and `clientInfo` to include `deviceModel`
for better compatibility.
- Changed the default client from `AndroidClient` to `IOSClient`.
- Commented out `playerParams` in the video data request, addressing
video download issues.
- Minor code cleanup to improve readability.
@appleboy
Copy link
Contributor

Confirmed. It is working.

@shoce
Copy link

shoce commented Dec 20, 2024

@corny please give it a go

@shoce
Copy link

shoce commented Dec 20, 2024

for building my project temporarily i added to my go.mod file:

replace github.com/kkdai/youtube/v2 => github.com/ruizlenato/youtube/v2 master

@corny corny merged commit 9f98965 into kkdai:master Dec 20, 2024
2 of 4 checks passed
@corny
Copy link
Collaborator

corny commented Dec 21, 2024

Thanks for your fix. I've released a new version yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants