feat(Select): add ariaLabel prop

kiwicom · Dec 6, 2024 · 8d86f8e · 8d86f8e
1 parent e64f49f
commit 8d86f8e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/packages/orbit-components/src/Select/index.tsx b/packages/orbit-components/src/Select/index.tsx
@@ -40,6 +40,7 @@ const Select = React.forwardRef<HTMLSelectElement, Props>((props, ref) => {
     customValueText,
     insideInputGroup,
     dataAttrs,
+    ariaLabel,
   } = props;
   const filled = !(value == null || value === "");
 
@@ -67,6 +68,7 @@ const Select = React.forwardRef<HTMLSelectElement, Props>((props, ref) => {
       className={cx("relative block", spaceAfter && spaceAfterClasses[spaceAfter])}
       ref={inputRef}
       style={{ width }}
+      aria-label={label?.toString() || ariaLabel?.toString()}
     >
       {label && !inlineLabel && (
         <FormLabel
@@ -167,7 +169,6 @@ const Select = React.forwardRef<HTMLSelectElement, Props>((props, ref) => {
             onBlur={onBlur}
             onChange={onChange}
             tabIndex={tabIndex ? Number(tabIndex) : undefined}
-            id={selectId}
             required={required}
             ref={ref}
             aria-describedby={shown ? `${selectId}-feedback` : undefined}

diff --git a/packages/orbit-components/src/Select/types.d.ts b/packages/orbit-components/src/Select/types.d.ts
@@ -35,4 +35,5 @@ export interface Props extends Common.Globals, Common.SpaceAfter, Common.DataAtt
   readonly insideInputGroup?: boolean;
   readonly inlineLabel?: boolean;
   readonly customValueText?: Common.Translation;
+  readonly ariaLabel?: Common.Translation;
 }