Remove Python 2 support, six dependency #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're in the process of releasing version @rdb We now have some conflicts, can you take care of it? |
rdb
force-pushed
the
remove-py2-support
branch
from
f3b7899 to
95e3540
Compare
|
Sorry for the delay, I've addressed the merge conflicts and rebased. Tests pass locally on Linux.
This totally makes sense and is no problem for me, just wanted to point out that no Python 2 compatibility is broken by this PR, since pyjnius is already incompatible with Python 2 due to the use of f-strings :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this great project!
Python 2 is ancient history by now, and as pointed out in #618, pyjnius does not even work with Python versions under 3.6 at this point.
This PR removes the compatibility hacks for Python 2 and drops the now unnecessary dependency on the
sixpackage.