Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display error message when saving workflow with existing title #6354

Merged
merged 3 commits into from
Dec 22, 2024

Conversation

solth
Copy link
Member

@solth solth commented Dec 19, 2024

Fixes #6353

@BartChris
Copy link
Collaborator

BartChris commented Dec 19, 2024

The error message now propagates to the fronted, so the functionality is there.

image

One optimization could be to first check if the title already exists and if it does already exist, show a less technical and translated error message. The current error message is not translated and quite technical. If an error occurs for other reasons, we can probably show the technical message, because we do not know, what the reason is.

@solth
Copy link
Member Author

solth commented Dec 19, 2024

@BartChris I added a check and tried to clarify the error message. Does this work for you? (note: I didn't add a Spanish translation generated with Google Translate as @danilopenagos would have to check - and probably fix - it anyway)

Bildschirmfoto 2024-12-19 um 22 57 14

Copy link
Collaborator

@BartChris BartChris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@solth solth merged commit dfa8434 into kitodo:main Dec 22, 2024
5 checks passed
@solth solth deleted the workflow-error-message branch December 22, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message not displayed when trying to save new workflow with existing title
2 participants