Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case-insensitive search, filtering and sorting #5363

Merged

Conversation

thomaslow
Copy link
Collaborator

@thomaslow thomaslow commented Sep 26, 2022

Related issues:

This pull request changes the ElasticSearch mapping such that certain information is stored in lower-case form, which allows for case-insensitive search, filtering and sorting.

The following fields are changed to case-insensitivity by this pull request:

  • process.title
  • process.project.title
  • process.comments.message (the combination of all comment texts for a process)
  • task.title (e.g. Scanning, QC)
  • task.processForTask.title

Additional process meta data in "mdWrap.xmlData.kitodo.metadata.[something]" is already searched case-insensitive.

Example: You can case-insensitive search for a process title now:
image

Example: You can case-insensitive search for tasks in certain steps:
image

Example: You can case-insensitive sort process titles now:
image

@thomaslow thomaslow marked this pull request as ready for review October 6, 2022 14:10
@solth solth requested a review from oliver-stoehr October 17, 2022 09:05
Copy link
Collaborator

@oliver-stoehr oliver-stoehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only found a small typo in TaskServiceIT.java:262.
Apart from that everything looks good and works as intended.

Co-authored-by: Oliver Stöhr <[email protected]>
@solth solth merged commit b704e2e into kitodo:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extended Search: option to ignore upper and lower case Sort project titles case-insensitive
3 participants