Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4638 fix nullpointer exception in user detail #4639

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

markusweigelt
Copy link
Collaborator

@markusweigelt markusweigelt commented Sep 6, 2021

Fixes #4638

When user detail/edit is opened we check if ldap server is not null.

If ldap server is null a helper message will be shown.

@solth
Copy link
Member

solth commented Sep 7, 2021

If you link your pull request to the issue mentioned in the title a la "Fixes #4638" in the description, the issue will be closed automatically once the pull request gets merged. (see https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue for details)

@markusweigelt
Copy link
Collaborator Author

Changed null check using null check convention. To change log level of error messages issue #4645 is created.

Copy link
Collaborator Author

@markusweigelt markusweigelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes are resolved.

@Kathrin-Huber Kathrin-Huber merged commit fee4e40 into kitodo:master Sep 8, 2021
@markusweigelt markusweigelt deleted the #4638 branch September 8, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nullpointer exception in user detail
3 participants