Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Remove client-side paging redundancies #938

Draft
wants to merge 78 commits into
base: main
Choose a base branch
from

Display toolbox initialization only once

fea6f47
Select commit
Loading
Failed to load commit list.
Draft

[FEATURE] Remove client-side paging redundancies #938

Display toolbox initialization only once
fea6f47
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Aug 2, 2024 in 0s

3 new security issues (0 max.).

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 11
- Added 32
           

Complexity increasing per file
==============================
- Resources/Public/JavaScript/PageView/Toolbox.js  7
- Resources/Public/JavaScript/PageView/TableOfContents.js  9
- Resources/Public/JavaScript/PageView/Metadata.js  4
- Resources/Public/JavaScript/PageView/Controller.js  6
- Resources/Public/JavaScript/PageView/Navigation.js  4
- Classes/Controller/DocumentController.php  7
- Classes/Controller/MetadataController.php  1
- Classes/Controller/NavigationController.php  1
         

Complexity decreasing per file
==============================
+ Resources/Public/JavaScript/PageView/PageView.js  -2

See the complete overview on Codacy

Annotations

Check failure on line 467 in Classes/Controller/AbstractController.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Classes/Controller/AbstractController.php#L467 

Direct use of $GLOBALS Superglobal detected.

Check warning on line 546 in Classes/Controller/AbstractController.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Classes/Controller/AbstractController.php#L546 

The use of function intval() is discouraged; use (int) construction instead.

Check notice on line 550 in Classes/Controller/AbstractController.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Classes/Controller/AbstractController.php#L550 

Closing brace indented incorrectly; expected 8 spaces, found 16

Check notice on line 552 in Classes/Controller/AbstractController.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Classes/Controller/AbstractController.php#L552 

Line indented incorrectly; expected 4 spaces, found 5

Check notice on line 64 in Classes/Controller/DocumentController.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Classes/Controller/DocumentController.php#L64 

Space found before square bracket; expected "$filesConfiguration[" but found "$filesConfiguration ["

Check notice on line 65 in Classes/Controller/DocumentController.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Classes/Controller/DocumentController.php#L65 

Space found before square bracket; expected "$filesConfiguration[" but found "$filesConfiguration ["

Check warning on line 562 in Classes/Controller/PageViewController.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Classes/Controller/PageViewController.php#L562 

Avoid unused local variables such as '$initDoc'.

Check notice on line 562 in Classes/Controller/PageViewController.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Classes/Controller/PageViewController.php#L562 

Avoid using undefined variables such as '$initDoc' which will lead to PHP notices.

Check warning on line 3 in Resources/Public/Css/Kitodo.css

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/Css/Kitodo.css#L3 

Use of !important

Check notice on line 11 in Resources/Public/JavaScript/PageView/Controller.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/Controller.js#L11 

'dlfController' is defined but never used.

Check notice on line 106 in Resources/Public/JavaScript/PageView/Controller.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/Controller.js#L106 

'dlfUtils' is not defined.

Check notice on line 106 in Resources/Public/JavaScript/PageView/Controller.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/Controller.js#L106 

Method 'findFileByGroup' expected no return value.

Check notice on line 30 in Resources/Public/JavaScript/PageView/Metadata.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/Metadata.js#L30 

'dlfMetadata' is defined but never used.

Check notice on line 106 in Resources/Public/JavaScript/PageView/Metadata.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/Metadata.js#L106 

Default clause should be the last clause.

Check notice on line 11 in Resources/Public/JavaScript/PageView/Navigation.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/Navigation.js#L11 

'dlfNavigation' is defined but never used.

Check notice on line 355 in Resources/Public/JavaScript/PageView/PageView.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/PageView.js#L355 

'dlfViewerFullTextControl' is not defined.

Check notice on line 17 in Resources/Public/JavaScript/PageView/TableOfContents.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/TableOfContents.js#L17 

'dlfTableOfContents' is defined but never used.

Check notice on line 52 in Resources/Public/JavaScript/PageView/TableOfContents.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/TableOfContents.js#L52 

'e' is defined but never used.

Check notice on line 11 in Resources/Public/JavaScript/PageView/Toolbox.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/Toolbox.js#L11 

'dlfToolbox' is defined but never used.

Check notice on line 69 in Resources/Public/JavaScript/PageView/Toolbox.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/Toolbox.js#L69 

Expected a default case.

Check notice on line 7 in Resources/Public/JavaScript/PageView/types.d.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/types.d.ts#L7 

'ImageDesc' is defined but never used.

Check notice on line 8 in Resources/Public/JavaScript/PageView/types.d.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/types.d.ts#L8 

'FulltextDesc' is defined but never used.

Check notice on line 10 in Resources/Public/JavaScript/PageView/types.d.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/types.d.ts#L10 

'PageObject' is defined but never used.

Check notice on line 33 in Resources/Public/JavaScript/PageView/types.d.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/types.d.ts#L33 

'Loaded' is defined but never used.

Check notice on line 56 in Resources/Public/JavaScript/PageView/types.d.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Resources/Public/JavaScript/PageView/types.d.ts#L56 

'PageHistoryState' is defined but never used.
View more details on Codacy Production