Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENANCE] Remove database fields from ext_tables.sql which are referenced in TCA #1015

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[MAINTENANCE] Remove database fields from ext_tables.sql which are referenced in TCA #1015

wants to merge 1 commit into from

Conversation

beatrycze-volk
Copy link
Collaborator

Change for #399

@beatrycze-volk beatrycze-volk marked this pull request as draft September 15, 2023 13:07
@sebastian-meyer sebastian-meyer mentioned this pull request Sep 29, 2023
Open
15 tasks
@sebastian-meyer sebastian-meyer self-requested a review September 29, 2023 12:16
@sebastian-meyer sebastian-meyer added the 🛠 maintenance A task to keep the code up-to-date and manageable. label Sep 29, 2023
@sebastian-meyer sebastian-meyer changed the title Remove database fields from ext_tables.sql which are referenced in TCA [MAINTENANCE] Remove database fields from ext_tables.sql which are referenced in TCA Sep 29, 2023
@beatrycze-volk beatrycze-volk force-pushed the ext-tables branch 3 times, most recently from d9c37d4 to 5ce94bd Compare October 24, 2023 15:22
@beatrycze-volk
Copy link
Collaborator Author

I'm not really sure if this an error in the application or an error in the test setup. I'm going to make some updates in test setup and ten come back to this PR.

@beatrycze-volk
Copy link
Collaborator Author

@sebastian-meyer I have found the reason why those tests are failing. DB data must be imported as CSV instead of deprecated XML format. I'm currently transforming those files, but probably rest of newly inserted tests should be inserted with CSV files to avoid double work.

@beatrycze-volk beatrycze-volk mentioned this pull request Oct 27, 2023
Merged
@sebastian-meyer
Copy link
Member

Thanks for investigating! I didn't even know they changed that for TYPO3...

@oliver-stoehr Could you please consider this for the remaining pull requests which add new fixtures?

@beatrycze-volk
Copy link
Collaborator Author

At the end it looks that even after those changes it doesn't pass the tests. The database tables are still created incorrectly. They are missing fields removed from ext_tables.sql.

@sebastian-meyer sebastian-meyer linked an issue Jan 30, 2024 that may be closed by this pull request
Open Maintenance Tasks #399
Open
15 tasks
@sebastian-meyer
Copy link
Member

According to documentation this looks fine, but tests are still failing. Are we not using the extension manager to set the database up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-meyer sebastian-meyer Awaiting requested review from sebastian-meyer

At least 1 approving review is required to merge this pull request.

Assignees

@beatrycze-volk beatrycze-volk

Labels
🛠 maintenance A task to keep the code up-to-date and manageable.
Projects
None yet
Milestone
Kitodo.Presentation 5.1.0
Development

Successfully merging this pull request may close these issues.

Open Maintenance Tasks
2 participants
@beatrycze-volk @sebastian-meyer