Merge pull request #537 from sebastian-meyer/fix-xss-issue

Fix XSS issue
kitodo · Jul 30, 2020 · b028292 · b028292
2 parents 291efab + fee894c
commit b028292
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/Documentation/Settings.yml b/Documentation/Settings.yml
@@ -11,7 +11,7 @@ conf.py:
   copyright: 2017
   project: Kitodo.Presentation
   version: 2.3
-  release: 2.3.0
+  release: 2.3.1
   intersphinx_mapping:
     t3tsref:
     - http://docs.typo3.org/typo3cms/TyposcriptReference/

diff --git a/ext_emconf.php b/ext_emconf.php
@@ -21,7 +21,7 @@
     'uploadfolder' => TRUE,
     'createDirs' => '',
     'clearCacheOnLoad' => FALSE,
-    'version' => '2.3.0',
+    'version' => '2.3.1',
     'constraints' => array (
         'depends' => array (
             'php' => '7.0.0-',

diff --git a/plugins/listview/class.tx_dlf_listview.php b/plugins/listview/class.tx_dlf_listview.php
@@ -365,7 +365,7 @@ protected function getSortingForm() {
 
             if ($piVar != 'order' && $piVar != 'DATA' && !empty($value)) {
 
-                $sorting .= '<input type="hidden" name="'.$this->prefixId.'['.$piVar.']" value="'.htmlspecialchars($value).'" />';
+                $sorting .= '<input type="hidden" name="'.$this->prefixId.'['.preg_replace('/[^A-Za-z0-9_-]/', '', $piVar).']" value="'.htmlspecialchars($value).'" />';
 
             }
 

diff --git a/plugins/navigation/class.tx_dlf_navigation.php b/plugins/navigation/class.tx_dlf_navigation.php
@@ -75,7 +75,7 @@ protected function getPageSelector() {
 
             if ($piVar != 'page' && $piVars != 'DATA' && !empty($value)) {
 
-                $output .= '<input type="hidden" name="'.$this->prefixId.'['.$piVar.']" value="'.htmlspecialchars($value).'" />';
+                $output .= '<input type="hidden" name="'.$this->prefixId.'['.preg_replace('/[^A-Za-z0-9_-]/', '', $piVar).']" value="'.htmlspecialchars($value).'" />';
 
             }
-Original file line number
+Diff line change
@@ Expand Up / @@ -365,7 +365,7 @@ protected function getSortingForm() { @@
                 if ($piVar != 'order' && $piVar != 'DATA' && !empty($value)) {
-                    $sorting .= '<input type="hidden" name="'.$this->prefixId.'['.$piVar.']" value="'.htmlspecialchars($value).'" />';
+                    $sorting .= '<input type="hidden" name="'.$this->prefixId.'['.preg_replace('/[^A-Za-z0-9_-]/', '', $piVar).']" value="'.htmlspecialchars($value).'" />';
                 }
@@ Expand Down @@