generated from cloudwego/.github
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(p2) Added hessian2 enumeration support for dubbo (#88) #89
Open
s5364733
wants to merge
9
commits into
kitex-contrib:main
Choose a base branch
from
s5364733:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMwangnima
reviewed
Apr 15, 2024
DMwangnima
reviewed
Apr 15, 2024
OK
…---Original---
From: "Scout ***@***.***>
Date: Mon, Apr 15, 2024 20:09 PM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [kitex-contrib/codec-dubbo] feat(p2) Added hessian2 enumerationsupport for dubbo (#88) (PR #89)
@DMwangnima commented on this pull request.
In pkg/hessian2/enum/enum.go:
> + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package enum + +import ( + hessian "github.com/apache/dubbo-go-hessian2" +) + +const InvalidJavaEnum JavaEnum = -1
Why do we not refer to hessian.InvalidJavaEnum?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
因为模板生成的代码要经过codecdubbo所以这里直接考出来,避免用hessian2的包不能直接用
…---Original---
From: "Scout ***@***.***>
Date: Mon, Apr 15, 2024 20:09 PM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [kitex-contrib/codec-dubbo] feat(p2) Added hessian2 enumerationsupport for dubbo (#88) (PR #89)
@DMwangnima commented on this pull request.
In pkg/hessian2/enum/enum.go:
> + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package enum + +import ( + hessian "github.com/apache/dubbo-go-hessian2" +) + +const InvalidJavaEnum JavaEnum = -1
Why do we not refer to hessian.InvalidJavaEnum?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: s5364733 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Establishing a hessian2 bridge to the kitex client
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: