-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix alignment issue with default container width #22
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check on mobile? I guess it would be no margin now.
@jackahl also tell me if this is acceptable giving the initial specs of the block, and if it's going to affect existing projects. |
Maybe I don't fully get how flexbox works. However, won't the size of the logo affect this? On the screenshot, it looks pretty good though. |
No, my current implementation only changes the alignments of logo. |
@sneridagh screenshots |
I fixed it now. Margin is already removed. |
@sneridagh Please merge this. |
I tested it with two logos, I don't think this is what we have in mind: @tisto we can't go full width with the logos, can we meet and specify it a bit better? |
@jackahl which was the initial spec? |
@iFlameing I decided with Timo that this will go in .com only. We will use this solution for blocks >= 3, and the current solution for below this. So close this one, I will add a ticket for the .com site. |
@iFlameing I just realised that we didn't implement this. We decided that we will go with this fix (images tight with the container in .com only. |
@tisto @sneridagh Screenshots