-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
black: list / dict / tuple formatting #116
Conversation
f5af7a1
to
4e3aeb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for this one, im unsure if we could keep as-is all the definitions as it is more compact and easier to read even if this part is not black'ed.
src/croniter/croniter.py
Outdated
DOW_FIELD, | ||
SECOND_FIELD, | ||
YEAR_FIELD, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i mean up to that part of the code, below, changes are mergeable without any comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we remove the magic trailing commma the items that are not longer than 80 characters will not break into multi lines.
Let me try that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me pull these out of this PR real quick though so we can merge the rest.
4e3aeb0
to
2d6280e
Compare
Will open a new PR to figure out the "alphas" |
and Yes, of course, i will merge the non commentables ones, Thx again for the contribution ! |
I can set a longer line length, but unfortunately it may cause a bunch of other reformatting now :( How do you feel about this? #121 |
black: list / dict / tuple formatting
Part of #99