Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

black: list / dict / tuple formatting #116

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

evanpurkhiser
Copy link
Contributor

Part of #99

Copy link
Owner

@kiorky kiorky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this one, im unsure if we could keep as-is all the definitions as it is more compact and easier to read even if this part is not black'ed.

DOW_FIELD,
SECOND_FIELD,
YEAR_FIELD,
)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i mean up to that part of the code, below, changes are mergeable without any comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we remove the magic trailing commma the items that are not longer than 80 characters will not break into multi lines.

Let me try that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me pull these out of this PR real quick though so we can merge the rest.

@evanpurkhiser
Copy link
Contributor Author

Will open a new PR to figure out the "alphas"

@kiorky
Copy link
Owner

kiorky commented Oct 30, 2024

Will open a new PR to figure out the "alphas"

black --line-length 120 should solve this.

and Yes, of course, i will merge the non commentables ones, Thx again for the contribution !

@kiorky kiorky merged commit d7507bf into kiorky:master Oct 30, 2024
8 checks passed
@evanpurkhiser
Copy link
Contributor Author

I can set a longer line length, but unfortunately it may cause a bunch of other reformatting now :(

How do you feel about this? #121

kiorky added a commit that referenced this pull request Dec 16, 2024
black: list / dict / tuple formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants