[feature] [APPROXIMATION] Keep search bar filter when switching tabs

[manuartero]

#10

calling the filtering function on

• EnableDLCPokemon()
• DisableDLCPokemon()

note: Please keep in mind that I'm not familiar with this code base;
consider this only an approximation, something like "ey, I think this could be the way when I read your code, but you know it better ^^"

---

NOT READY TO MERGE

This isn't working as expected: it is needed to double tab for getting the filtered pokemon list.

suggestion

If I may, I have a suggestion: you can use React.useState() hook for doing some refactoring:

On component creation you fetch both Pokemon lists and store them:

const [baseGamePoke, setBaseGamePoke] = React.useState([]);
const [armorPoke, setArmorPoke] = React.useState([]);

React.useEffect(() => {
        let isSubscribed = true;
        fetchPokemon().then(items => {
            if (isSubscribed) {
              // some coding here for obtaining both arrays
              setBaseGamePoke( /* [....] */ );
              setArmorPoke( /* [...] */ );
            }
        });
        const cleanUp = () => {
            isSubscribed = false;
        };
        return cleanUp;
    }, []); // will execute on component did mount

having that working will grant you the simplest filtering ever !!!! :), something like:

 const [filterValue, setFilterValue] = React.useState('');
const [filteredBaseGamePokemon, setFilteredBaseGamePokemon] = React.useState([])
const [filteredArmourPokemon, setFilteredArmourPokemon] = React.useState([])

    React.useEffect(() => {
        if (filterFn && arePokemonReady) {
                const filteredBaseGamePokemon = [
                    ....filter(pk => filterFn()),
                ];
                ...
                setFilteredBaseGamePokemon(filteredBaseGamePokemon);
                ....
            } 
        }
    }, [filterValue]); // execute when the search bar changes

Now, you may show in the list filteredBaseGamePokemon and filteredArmourPokemon (instead of baseGamePoke which you want to keep fresh for filtering)

[kikisaints]

This is awesome! Thanks for the suggestion - I have a few changes I forgot to push that fixes that list refresh issue. I'm getting a work break coming up soon so I think I'll be able to put some time into fixing and adding this feature!

[manuartero]

I'm going to close this pr if you don't mind :)