Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Keep search when switching tabs #10

Open
manuartero opened this issue Jul 20, 2020 · 1 comment
Open

[feature request] Keep search when switching tabs #10

manuartero opened this issue Jul 20, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@manuartero
Copy link

manuartero commented Jul 20, 2020

Hi there.

I've a feature request:

  1. Jane opens the app
  2. Jane search for (example) #water
    => App shows only Water type pokemon
  3. Jane tabs over Isle of Armor tab
    (current) => App shows every Pokemon from the DLC
    (desired) => App shows only Water type pokemon from the DLC

Thanks :)

@manuartero
Copy link
Author

manuartero commented Jul 20, 2020

I took the liberty of downloading your code and tried it myself , it worked smoothly 👍 , I opened a PR with an approximation for doing this but I don't expect you merge that but rather take a look, take the idea, and finish it

I created a gif too:

galar-issue

@kikisaints kikisaints self-assigned this Oct 28, 2020
@kikisaints kikisaints added the enhancement New feature or request label Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants