[JBPM-10078] Integration test for timer migration from 6.4 #24
Conversation
| <testResources> | ||
| <testResource> | ||
| <directory>src/test/resources</directory> | ||
| <filtering>false</filtering> |
There was a problem hiding this comment.
not really needed, since maven filtering is set to false by default
| </goals> | ||
| <configuration> | ||
| <outputDirectory>${project.build.directory}/drivers</outputDirectory> | ||
| <includeGroupIds>mysql</includeGroupIds> |
There was a problem hiding this comment.
not really sure what driver version will be used? latest one?
| <org.kie.samples.server>kie-server</org.kie.samples.server> | ||
| <org.jbpm.ejb.timer.local.cache>false</org.jbpm.ejb.timer.local.cache> | ||
| <org.jbpm.ejb.timer.tx>true</org.jbpm.ejb.timer.tx> | ||
| <org.kie.samples.image.postgresql>postgres:${image.postgresql.version}</org.kie.samples.image.postgresql> |
There was a problem hiding this comment.
shouldn't we define mysql:tag image here instead of postgresql? and it should be pick up as a system property in the test class
|
|
||
| import com.google.common.io.Files; | ||
|
|
||
| public class KieJarBuildHelper { |
There was a problem hiding this comment.
This class is not needed or used in this module
| <logger name="org.testcontainers" level="info"/> | ||
| <logger name="com.github.dockerjava" level="info"/> | ||
|
|
||
| <root level="trace"> |
There was a problem hiding this comment.
maybe debug or info is enough level, wdyt?
| } | ||
|
|
||
| @AfterAll | ||
| public static void tearDown() throws Exception { |
| } | ||
|
|
||
| @Test | ||
| void testEJBTimerWithRollback() throws InterruptedException, SQLException { |
There was a problem hiding this comment.
same, no need to declare these exceptions
| ADD etc/jbpm-flow-7.69.0.Final.jar /WEB-INF/lib/jbpm-flow-7.69.0.Final.jar | ||
|
|
||
| RUN if [ -z "$NO_PATCH" ]; then \ | ||
| rm $JBOSS_HOME/standalone/deployments/kie-server.war/WEB-INF/lib/jbpm-flow-7.69.0.Final.jar; \ |
There was a problem hiding this comment.
There is an issue here. Since the image we are using it's based on quay.io/kiegroup/kie-server-showcase:7.70.0.Final the WEB-INF/lib/jbpm-flow-7.69.0.Final.jar will not exist.
Must be
| rm $JBOSS_HOME/standalone/deployments/kie-server.war/WEB-INF/lib/jbpm-flow-7.69.0.Final.jar; \ | |
| rm $JBOSS_HOME/standalone/deployments/kie-server.war/WEB-INF/lib/jbpm-flow-7.70.0.Final.jar; \ |
Though if this is the case, maybe the patch is already included in 7.70.0.Final version?
| <org.jbpm.ejb.timer.local.cache>false</org.jbpm.ejb.timer.local.cache> | ||
| <org.jbpm.ejb.timer.tx>true</org.jbpm.ejb.timer.tx> |
There was a problem hiding this comment.
these 2 properties belong to ejb timers, so not needed here
| List<TimerInstance> timers = processAdminClient.getTimerInstances(containerId, processInstanceId); | ||
|
|
||
| assertEquals(1, timers.size()); | ||
|
|
||
| timers = processAdminClient.getTimerInstances(containerId, 6L); | ||
|
|
||
| logger.info("Retrieving timers for process 6; timers[6]: "+timers); | ||
|
|
||
| assertEquals(1, timers.size()); |
There was a problem hiding this comment.
as already discussed, not sure about the migration process, since we are loading a mysql by using jbpm schemas version 6, and then we create a process instance through a kie-server 7.x? shouldn't we migrate the instance first? or am I missing anything here?
Reproducer to validate fix provided by jbpm#2149