feat(community): 학부소식 페이지 추가 #39

SunwooJaeho · 2024-12-02T17:30:33Z

Summary

#30

학부소식 페이지 퍼블리싱을 진행하였어요.

Tasks

remote.ts 파일 위치 변경
학부소식 페이지 퍼블리싱

Screenshot

페이지의 디자인은 공지사항 페이지와 동일해요.

coderabbitai · 2024-12-02T17:30:39Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

m2na7 · 2024-12-03T01:10:37Z

apps/community/src/app/board/news/page.tsx

+export default async function NewsPage(props: {
+  searchParams?: Promise<{
+    category?: string;
+    page?: string;
+    keyword?: string;
+  }>;


해당 타입을 따로 분리해주는건 어떨까요 ?
공지사항 페이지에도 공통으로 사용되는 부분으로 보여요

공통적으로 사용하지만 성급한 추상화가 될 수 있다고 생각해요. 나중에 요구사항이 변경되어 공지사항과 학부소식이 동일하지 않는 파라미터로 사용할 수도 있는 가능성도 생각하여, 지금 처럼 복잡하지 않는 상태를 추상화하지 않고 두는 것도 괜찮다고 생각해요. 한 번 추상화나 레이어가 생긴다면 의존성과 커플링이 생겨버리니까요. 다른 분들 의견이 궁금합니다

@kgu-developers/1-client

저도 파라미터 변경 가능성이 있다고 생각하여 추상화하지 않았습니다!

apps/community/src/app/board/news/page.tsx

gwansikk · 2024-12-03T08:11:00Z

apps/community/src/app/board/news/page.tsx

+export default async function NewsPage(props: {
+  searchParams?: Promise<{
+    category?: string;
+    page?: string;
+    keyword?: string;
+  }>;


공통적으로 사용하지만 성급한 추상화가 될 수 있다고 생각해요. 나중에 요구사항이 변경되어 공지사항과 학부소식이 동일하지 않는 파라미터로 사용할 수도 있는 가능성도 생각하여, 지금 처럼 복잡하지 않는 상태를 추상화하지 않고 두는 것도 괜찮다고 생각해요. 한 번 추상화나 레이어가 생긴다면 의존성과 커플링이 생겨버리니까요. 다른 분들 의견이 궁금합니다

@kgu-developers/1-client

gwansikk · 2024-12-03T08:14:53Z

apps/community/src/app/board/notice/page.tsx

@@ -20,7 +20,7 @@ export default async function BoardPage(props: {
  const currentPage = Number(searchParams?.page) || 0;
  const keyword = searchParams?.keyword || '';

-  const { data } = await getBoards(currentPage, 10, keyword, '공지사항');
+  const { data } = await getBoards(currentPage, 10, keyword, 'DEPT_INFO');


getBoards의 인터페이스가 복잡해지고 있어요. 현재는 4개인데요, 해당 인터페이스의 순서를 외우기는 어렵다고 생각해요(변수명이 keyword가 아닌 다른 변수명일 때 바로 유추하기 어려움)

때문에 3개 혹은 4개 이상의 파라미터를 넘겨야 한다면 저는 RORO 패턴을 사용하는데요. 객체 형태로 하나만 넘겨서 타입적으로 보장받고, 넘기는 값에 대해 쉽게 확인할 수 있어요(React-Query가 사용하는 인터페이스)

ref:

https://taegon.kim/archives/8058

https://tanstack.com/query/v5/docs/framework/react/reference/useQuery

수정 완료하였습니다!👍

gwansikk

cool 👍👍

gwansikk · 2024-12-03T10:24:22Z

apps/community/src/app/board/remote.ts

+  page: number;
+  size: number;
+  keyword?: string;
+  category: string;


Suggested change

category: string;

category: 'DEPT_INFO' | 'DEPT_NEWS';

SunwooJaeho added 2 commits December 3, 2024 02:28

chore: remote.ts 파일 위치 변경

10c1a99

feat: 학부소식 페이지

8970209

SunwooJaeho added the enhancement New feature or request label Dec 2, 2024

SunwooJaeho self-assigned this Dec 2, 2024

SunwooJaeho requested review from wontory and gwansikk as code owners December 2, 2024 17:30

SunwooJaeho linked an issue Dec 2, 2024 that may be closed by this pull request

[Feature]: 학부소식 페이지 #30

Closed

1 task

refactor: category 값 변경

d309b48

SunwooJaeho requested a review from m2na7 December 2, 2024 17:49

m2na7 reviewed Dec 3, 2024

View reviewed changes

gwansikk requested changes Dec 3, 2024

View reviewed changes

SunwooJaeho added 2 commits December 3, 2024 17:25

refactor: pagination props 변경

fde13cc

refactor: roro 패턴 적용

7eb11fd

gwansikk approved these changes Dec 3, 2024

View reviewed changes

SunwooJaeho merged commit ffe6c38 into develop Dec 3, 2024
3 checks passed

SunwooJaeho deleted the feature/news-page branch December 3, 2024 10:42

SunwooJaeho restored the feature/news-page branch December 3, 2024 10:43

SunwooJaeho deleted the feature/news-page branch December 3, 2024 10:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(community): 학부소식 페이지 추가 #39

feat(community): 학부소식 페이지 추가 #39

SunwooJaeho commented Dec 2, 2024

coderabbitai bot commented Dec 2, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

m2na7 Dec 3, 2024

gwansikk Dec 3, 2024 •

edited

Loading

SunwooJaeho Dec 3, 2024

gwansikk Dec 3, 2024 •

edited

Loading

gwansikk Dec 3, 2024 •

edited

Loading

SunwooJaeho Dec 3, 2024

gwansikk left a comment •

edited

Loading

gwansikk Dec 3, 2024

feat(community): 학부소식 페이지 추가 #39

feat(community): 학부소식 페이지 추가 #39

Conversation

SunwooJaeho commented Dec 2, 2024

Summary

Tasks

Screenshot

coderabbitai bot commented Dec 2, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

m2na7 Dec 3, 2024

Choose a reason for hiding this comment

gwansikk Dec 3, 2024 • edited Loading

Choose a reason for hiding this comment

SunwooJaeho Dec 3, 2024

Choose a reason for hiding this comment

gwansikk Dec 3, 2024 • edited Loading

Choose a reason for hiding this comment

gwansikk Dec 3, 2024 • edited Loading

Choose a reason for hiding this comment

SunwooJaeho Dec 3, 2024

Choose a reason for hiding this comment

gwansikk left a comment • edited Loading

Choose a reason for hiding this comment

gwansikk Dec 3, 2024

Choose a reason for hiding this comment

CodeRabbit Configuration File (`.coderabbit.yaml`)

gwansikk Dec 3, 2024 •

edited

Loading

gwansikk Dec 3, 2024 •

edited

Loading

gwansikk Dec 3, 2024 •

edited

Loading

gwansikk left a comment •

edited

Loading