feat(community): 구성원 소개 페이지 퍼블리싱 #23
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 Walkthrough📝 Walkthrough📝 WalkthroughWalkthrough이 변경 사항은 Next.js 애플리케이션의 이미지 처리 기능을 향상시키기 위해 Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| {!imgError ? ( | ||
| <Image | ||
| src={professor.img ?? 'https://placehold.co/128'} | ||
| width={100} | ||
| height={100} | ||
| className={styles.avatarImage} | ||
| alt={professor.name} | ||
| onError={() => setImgError(true)} | ||
| /> | ||
| ) : ( |
There was a problem hiding this comment.
대체 이미지가 있는데 error state를 둔 이유가 있나요?
error state 빼면 서버 컴포넌트로도 가능할 것 같아요!
There was a problem hiding this comment.
해당 이미지는 외부 url을 통해 불러오기 때문에 onError를 활용하는 방안을 유지했고, placehold 이미지는 필요가 없다고 판단되어 삭제 조치했습니다!
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range comments (1)
apps/community/next.config.ts (1)
Line range hint
8-18:images설정이 중복되어 있습니다.
nextConfig객체 내에images설정이 두 번 정의되어 있습니다. 두 번째 설정(23-35줄)만 적용되고 첫 번째 설정(8-18줄)은 무시됩니다.다음과 같이 중복된 설정을 제거하고 하나로 통합하세요:
const nextConfig: NextConfig = { - images: { - remotePatterns: [ - { - protocol: 'https', - hostname: 'placehold.co', - }, - { - protocol: 'https', - hostname: 'www.kyonggi.ac.kr', - }, - ], - }, experimental: { reactCompiler: true, }, images: { remotePatterns: [ { protocol: 'https', hostname: 'kutis.kyonggi.ac.kr', pathname: '/webkutis/**', }, { protocol: 'https', hostname: 'placehold.co', }, ], }, };Also applies to: 23-35
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (1)
apps/community/next.config.ts(1 hunks)
🔇 Additional comments (2)
apps/community/next.config.ts (2)
31-33: placehold.co 도메인에 대한 보안 설정 검토가 필요합니다.
이전 리뷰에서 지적된 보안 문제가 아직 해결되지 않았습니다. placehold.co 도메인에 대한 pathname 제한이 없어 보안상 위험할 수 있습니다.
26-29: kutis.kyonggi.ac.kr 도메인 설정을 검증해주세요.
새로 추가된 kutis.kyonggi.ac.kr 도메인의 경우:
- pathname이
/webkutis/**로 제한되어 있어 보안상 좋습니다. - 하지만 이 경로가 실제로 교수 이미지를 제공하는 올바른 경로인지 확인이 필요합니다.
✅ Verification successful
kutis.kyonggi.ac.kr 도메인 설정이 올바르게 구성되어 있습니다
코드베이스 분석 결과:
/webkutis/TransferImageStreamHJ.do경로가 교수 이미지를 제공하는 실제 엔드포인트로 확인됨- professor.ts 목업 데이터에서 해당 URL이 교수 프로필 이미지로 사용되고 있음
- next.config.ts의 pathname: '/webkutis/**' 설정이 실제 사용되는 경로와 일치함
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify image URLs in the codebase that use kutis.kyonggi.ac.kr domain
# Search for image URLs in the codebase
rg -i "kutis\.kyonggi\.ac\.kr/webkutis" --type ts --type tsx
Length of output: 90
Script:
#!/bin/bash
# Search for image URLs in the codebase with broader file types and patterns
rg -i "kutis\.kyonggi\.ac\.kr" -t js -t jsx -t ts -t typescript
# Also check for any Next.js image configurations
rg -i "images.*kyonggi" -t js -t jsx -t ts -t typescript
# List all files that might contain image-related code
fd -e tsx -e ts -e js -e jsx | grep -i "image"
Length of output: 227
Script:
#!/bin/bash
# Search for any references to kutis.kyonggi.ac.kr in all text files
rg -i "kutis\.kyonggi\.ac\.kr"
# Find and examine next.config files
fd "next.config" --type f --exec cat {}
# Look for image-related configurations
rg -i "images.*=" --type-add 'ts:*.ts' --type ts
Length of output: 7177
apps/community/src/app/member/professor/components/ProfessorCard.tsx
Outdated
Show resolved
Hide resolved
…gu-developers/aics-client into feature/publishing-member-page
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Summary
구성원 페이지에 대해 퍼블리싱을 진행하였어요.
Tasks
Summary by CodeRabbit
새로운 기능
Page컴포넌트 추가.ProfessorCard컴포넌트 추가.스타일
기타
Professor인터페이스 및PROFESSORS배열 추가.