Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(community): 학부 소개 페이지 추가 #22

Merged
merged 9 commits into from
Nov 14, 2024
Merged

Conversation

gwansikk
Copy link
Member

@gwansikk gwansikk commented Nov 13, 2024

Summary

#19

학부 소개 페이지를 구현했습니다.

Tasks

  • 학부 소개 페이지에서 사용하는 list, section, title 컴포넌트를 추가했습니다.
  • 학부 소개 페이지를 구현했습니다.

To Reviewer

  • breadcrumb 컴포넌트는 아직 구현하지 않았습니다. (추후에 디자인 시스템에 추가 예정)

Screenshot

image

Summary by CodeRabbit

  • 새로운 기능
    • List, Section, 및 Dept 컴포넌트를 포함하여 부서 소개 페이지를 위한 새로운 구성 요소가 추가되었습니다.
    • 각 전공에 대한 세부 정보를 포함하는 섹션과 교육 목표를 나열하는 리스트가 포함되었습니다.
  • 스타일
    • 리스트 및 섹션의 스타일을 정의하는 새로운 CSS 모듈이 추가되었습니다.

@gwansikk gwansikk self-assigned this Nov 13, 2024
@gwansikk gwansikk requested a review from wontory as a code owner November 13, 2024 09:09
@gwansikk gwansikk linked an issue Nov 13, 2024 that may be closed by this pull request
Copy link
Contributor

coderabbitai bot commented Nov 13, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

이 변경 사항은 새로운 React 컴포넌트인 List, Section, Dept를 포함하여, 각각의 CSS 모듈을 통해 스타일링을 추가합니다. List 컴포넌트는 제목과 자식 요소를 받아 목록을 표시하며, Section 컴포넌트는 섹션 제목과 내용을 포함합니다. Dept 컴포넌트는 학부 개요를 구성하고, 여러 섹션과 목록을 통해 교육 목표를 설명합니다. 추가로, 레이아웃을 정의하는 layout.tsx 파일이 생성되었습니다.

Changes

파일 경로 변경 요약
apps/community/src/app/about/components/list.css.ts listlistTitle 스타일 추가 및 내보내기.
apps/community/src/app/about/components/list.tsx ListRow 컴포넌트 추가. List는 제목과 자식 요소를 받고, Row는 개별 목록 항목을 렌더링.
apps/community/src/app/about/components/section.css.ts sectionsectionTitle 스타일 추가 및 내보내기.
apps/community/src/app/about/components/section.tsx SectionTitle 컴포넌트 추가. TitleSection의 정적 속성으로 설정됨.
apps/community/src/app/about/dept/layout.tsx metadata 객체 및 RootLayout 함수 추가.
apps/community/src/app/about/dept/page.tsx Dept 컴포넌트 추가, 여러 SectionList 컴포넌트를 사용하여 학부 개요를 구성.

Possibly related PRs

Suggested reviewers

  • wontory

🐰 새로운 리스트와 섹션이 생겼어요,
학부 소개도 함께하니 기쁘죠!
제목과 내용이 잘 어우러져,
교육 목표를 모두에게 전해요.
귀여운 리스트, 섹션의 조화,
모두 함께하는 멋진 변화! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]

This comment was marked as off-topic.

@wontory wontory added the enhancement New feature or request label Nov 13, 2024
Copy link
Member

@wontory wontory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

컴포넌트 정의할 때 컨벤션 논의가 안됐던 것 같네요.

저는

컴포넌트 -> function
그 외 -> const = () => {}

이렇게 사용하고 있는데 통일이 필요해보입니다!

coderabbitai[bot]

This comment was marked as off-topic.

@gwansikk
Copy link
Member Author

gwansikk commented Nov 14, 2024

컴포넌트 정의할 때 컨벤션 논의가 안됐던 것 같네요.

// page
function Page {}

// component
const Component = () => {}

저는 개인적으로 이렇게 사용하는데요 페이지와 컴포넌트 그리고 함수와 구분하기 위해 선언 방식을 다르게 하고 있어요. 관련하여 팀 내 컨벤션으로 잡아야 하니 다른 분들 의견도 부탁드려요. @SunwooJaeho @m2na7

@m2na7
Copy link
Member

m2na7 commented Nov 14, 2024

컴포넌트 정의할 때 컨벤션 논의가 안됐던 것 같네요.

// page
export default function Page() {}

// component
function Component() {}

이렇게 컨벤션을 정했던 것 같은데, 저는 사실 화살표 함수 방식을 선호해서,

// component
const Component = () => {}

해당 방식으로 진행해도 좋을 것 같아요. ( + page는 Default Export, components는 Named Export 맞죠? )
@gwansikk @SunwooJaeho @wontory

coderabbitai[bot]

This comment was marked as off-topic.

@gwansikk gwansikk merged commit 0a8638a into develop Nov 14, 2024
2 checks passed
@gwansikk gwansikk deleted the feature/dept branch November 14, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: 학부 소개 페이지
3 participants