-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(community): 학부 소개 페이지 추가 #22
Conversation
Caution Review failedThe pull request is closed. Walkthrough이 변경 사항은 새로운 React 컴포넌트인 Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
컴포넌트 정의할 때 컨벤션 논의가 안됐던 것 같네요.
저는
컴포넌트 ->
function
그 외 ->const = () => {}
이렇게 사용하고 있는데 통일이 필요해보입니다!
저는 개인적으로 이렇게 사용하는데요 페이지와 컴포넌트 그리고 함수와 구분하기 위해 선언 방식을 다르게 하고 있어요. 관련하여 팀 내 컨벤션으로 잡아야 하니 다른 분들 의견도 부탁드려요. @SunwooJaeho @m2na7 |
이렇게 컨벤션을 정했던 것 같은데, 저는 사실 화살표 함수 방식을 선호해서,
해당 방식으로 진행해도 좋을 것 같아요. ( + page는 Default Export, components는 Named Export 맞죠? ) |
Summary
학부 소개 페이지를 구현했습니다.
Tasks
To Reviewer
Screenshot
Summary by CodeRabbit
List
,Section
, 및Dept
컴포넌트를 포함하여 부서 소개 페이지를 위한 새로운 구성 요소가 추가되었습니다.