Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused JEST environment variable from examples/testing #8854

Merged
merged 5 commits into from
Oct 10, 2023

Conversation

dcousens
Copy link
Member

@dcousens dcousens commented Oct 10, 2023

This pull request, in addition to the title, prefers context.db.* calls rather than graphql.raw, which should arguably only be used for custom mutations at this time - and even then, we should introduce context.query.{customMutation} at some point.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 10, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4520784:

Sandbox Source
@keystone-6/sandbox Configuration

@dcousens dcousens requested a review from borisno2 October 10, 2023 01:21
@dcousens dcousens self-assigned this Oct 10, 2023
@dcousens dcousens changed the title Drop JEST environment variable from examples/testing Drop unused JEST environment variable from examples/testing Oct 10, 2023
@dcousens dcousens enabled auto-merge (squash) October 10, 2023 01:39
@dcousens dcousens merged commit 62146aa into main Oct 10, 2023
57 checks passed
@dcousens dcousens deleted the no-jest-worker branch October 10, 2023 01:40
@dcousens dcousens mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants