Migrate frontend to use Tapir endpoints #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolgab
commented
Sep 11, 2022
Comment on lines
+12
to
+41
| class RetryingBackend[P]( | ||
| delegate: SttpBackend[Future, P] | ||
| )(using stability: Stability) | ||
| extends DelegateSttpBackend[Future, P](delegate): | ||
| import scala.concurrent.ExecutionContext.Implicits.global | ||
|
|
||
| private given retry.Success[ | ||
| (Request[?, ?], Either[Throwable, Response[?]]) | ||
| ]((req, res) => !RetryWhen.Default(req, res)) | ||
|
|
||
| // The default timer is currently broken in JS | ||
| // https://github.com/softwaremill/odelay/pull/19 | ||
| private given odelay.Timer = odelay.js.JsTimer.newTimer | ||
|
|
||
| override def send[T, R >: P & Effect[Future]]( | ||
| request: Request[T, R] | ||
| ): Future[Response[T]] = | ||
| retry | ||
| .Backoff(stability.maxRetries, stability.delay) | ||
| .apply { | ||
| delegate | ||
| .send(request) | ||
| .transform(tryResponse => | ||
| scala.util.Success((request, tryResponse.toEither)) | ||
| ) | ||
| } | ||
| .flatMap { | ||
| case (_, Right(response)) => Future.successful(response) | ||
| case (_, Left(exception)) => Future.failed(exception) | ||
| } |
There was a problem hiding this comment.
MIgrating api.stability to Futures and to be used in sttp wasn't trivial, so I reimplemented an exponential backoff retrying backend using retry.
I left the original file in case we want to migrate it later.
There was a problem hiding this comment.
I think it's fine to remove it completely - though I would've imagined that sttp has a retying backend built-in given that both libraries are part of softwaremillverse :D
There was a problem hiding this comment.
It might be an interesting thing to try, actually! But as far as I know, there is no retry integration for sttp.
There was a problem hiding this comment.
Opened an issue here
keynmol
reviewed
Sep 11, 2022
|
Good to go from my side |
keynmol
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.