feat(web): initial integration of gesture staging 🐵 #9605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
…t path resolutions
jahorton
force-pushed
the
feat/web/gesture-staging
branch
from
9149693 to
5b6932a
Compare
jahorton
force-pushed
the
feat/web/gesture-staging-integration
branch
from
91bb6f1 to
ca4ce8c
Compare
…ture-staging-integration
…ture-staging-integration
mcdurdin
approved these changes
Sep 28, 2023
The ones I could find (via CTRL-F) when looking at this PR's changeset are all addressed by later PRs that have already been made - generally, by #9624 or before. |
Base automatically changed from
feat/web/gesture-staging
to
feature-gestures
September 29, 2023 08:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until this point, all the fancy gesture-processing code has been completely headless and not integrated with the touchpath-tracking code. While the
GestureSourceclass is used in both places, that was about the only bit of common code between the two areas. Until now.This PR integrates all the gesture-processing layers with the
TouchpointCoordinatorclass, the headless-capable base class of the top-level object for thegesture-recognizerlibrary-engine. As such, this change will allow actual detection of gestures from live, interactive inputs... not that we're testing those quite yet.While the new tests only cover integration for the cases already handled - and thus modipress and flick are still not covered - it does a new test for the blocking of additional new gestures during subkey-selection. (This was not viable with just the 'sequencing' layer when not integrated due to its requirements.) As a result, this adds coverage for the
selectionModesetting introduced in #9455, which is something that will also be used by modipresses, so we are at least a bit closer in that regard.@keymanapp-test-bot skip