Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(resources): ldml: update to keyboard3 🙀 #9588

Merged
merged 7 commits into from
Sep 21, 2023
Merged

chore(resources): ldml: update to keyboard3 🙀 #9588

merged 7 commits into from
Sep 21, 2023

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Sep 19, 2023 •
edited
Loading

@srl295 srl295 self-assigned this Sep 19, 2023
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Sep 19, 2023 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A17S22 milestone Sep 19, 2023
@srl295
Copy link
Member Author

srl295 commented Sep 19, 2023

implements unicode-org/cldr#3274

Base automatically changed from feat/developer/9515-drop-u1234-epic-ldml to master September 19, 2023 14:26
@srl295 srl295 marked this pull request as ready for review September 20, 2023 00:03
@srl295
Copy link
Member Author

srl295 commented Sep 20, 2023

timeout like it's dumping core here… strange.

@srl295
Copy link
Member Author

srl295 commented Sep 20, 2023

upstream is merged, will re-update

mcdurdin
mcdurdin approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whew a lot of fiddly there, hope you had fun making that change!

resources/standards-data/ldml-keyboards/techpreview/fetch-latest-cldr-techpreview.sh
Comment on lines +62 to +63
# delete old files, no reason to keep them
rm -vf dtd/{ldmlKeyboard,ldmlPlatform}.{xsd,dtd}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't be needed for long, of course

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# delete old files, no reason to keep them
rm -vf dtd/{ldmlKeyboard,ldmlPlatform}.{xsd,dtd}
# delete old draft spec files, no reason to keep them
rm -vf dtd/{ldmlKeyboard,ldmlPlatform}.{xsd,dtd}

Copy link
Member Author

@srl295 srl295 Sep 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "rm" will be needed because these are the files requested to be re added to CLDR. The pre 3.0 that the CLDR ticket requested to be reinstated.

@mcdurdin
Copy link
Member

Looks like you may need to throw the failing unit tests into a debugger to find out what is causing them to abort. At least it seems consistent cross-platform

@srl295
Copy link
Member Author

srl295 commented Sep 20, 2023 •
edited
Loading

  • upstream is merged, so this can use a refresh.
  • also, other changes afoot on the CLDR side, so I may just keep this one around a while.
  • … besides bug squashing here of course!

@srl295
Merge remote-tracking branch 'upstream/master' into chore/resources/k…
e2ca32b 
…eyboard3-epic-ldml
@srl295
chore(resources): ldml update keyboard -> keyboard3 🙀
0a8eec1 
For: #9604

- unicode-org/cldr:f3daab445e2e3ee88f8b94c6b46d380777035051
- un-deleting pcm, still in progress
@srl295
chore(core): ldml update keyboard -> keyboard3 🙀
9add2cb 
For: #9604

- yes, C++ changes also
@srl295
chore(core): ldml update keyboard -> keyboard3 🙀
60295ce 
For: #9604

- DOCTYPE fixes (typos) to make the red squiggles go away
@srl295
Copy link
Member Author

srl295 commented Sep 21, 2023

it was just the test runner that needed an update.

rc-swag
rc-swag approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@rc-swag rc-swag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@srl295
Copy link
Member Author

srl295 commented Sep 21, 2023

I'll make sure they are expected failures then merge.

@srl295 srl295 merged commit 2ac6357 into master Sep 21, 2023
2 checks passed
@srl295 srl295 deleted the chore/resources/keyboard3-epic-ldml branch September 21, 2023 20:09
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.179-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rc-swag rc-swag rc-swag approved these changes

@mcdurdin mcdurdin mcdurdin approved these changes

@jahorton jahorton Awaiting requested review from jahorton jahorton is a code owner

@darcywong00 darcywong00 Awaiting requested review from darcywong00 darcywong00 is a code owner

Assignees

@srl295 srl295

Labels
chore common/resources/ Build infrastructure common/web/ common/ core/ Keyman Core developer/compilers/ developer/ epic-ldml
Projects
None yet
Milestone
A17S22
Development

Successfully merging this pull request may close these issues.

chore(common): support resources updates to LDML for compatibility 🙀
4 participants
@srl295 @mcdurdin @keyman-server @rc-swag