Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: merge master into epic/ldml-editor 🗼 #12847

Open
wants to merge 201 commits into
base: epic/ldml-editor
Choose a base branch
from
Open

chore: merge master into epic/ldml-editor 🗼 #12847

wants to merge 201 commits into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Dec 24, 2024

mcdurdin and others added 30 commits October 7, 2024 14:27
@mcdurdin
chore(developer): add baseline tests for bcp47 codes to kmc-package
2b7ceff 
Relates-to: #12012
@sgschantz
add resizeKeyboard logging
246efb4
@sgschantz
correct resizeKeyboard logging
751c853
@sgschantz
fix(ios): add Adjust Keyboard Height control to Keyman Settings
0fbf123
@sgschantz
feat(ios): add KeyboardHeightViewController
7b69bed
@sgschantz
fix(ios): add subviews for keyboard height adjustment
8695112
@sgschantz
fix(ios): add debug logs
048b317
@sgschantz
fix(ios): more image layout debugging and experimenting
6decb5d
@sgschantz
fix(ios): fix keyboard height layout for portrait
9ff6d70
@srl295
feat(core): ldml: scaffolding for testing get_key_list()
dd11a25 
- move some test utils to statics
- add a new test action type and `@@key-list` keyword
- print warning on unhanded @-commands

Fixes: #12298
@srl295
feat(core): ldml: implementation for testing get_key_list()
382b511 
- ldml::vkeys class updated to keep a set<> of keys
- fix the test case to not leak!

Fixes: #12298
@srl295
Merge branch 'master' into fix/core/12298-get-key-list
cfda52b
@srl295
Merge branch 'master' into fix/core/12298-get-key-list
741d305
@sgschantz
fix(ios): fully functional UI for keyboard height change
9035414 
need to handle persistance to UserDefaults
@sgschantz
fix(ios): save keyboard height in UserDefaults
b620e17
@sgschantz
fix(ios): check for existence of UserDefault setting before read
a8949ef
@sgschantz
fix(ios): write new height values to UserDefaults
8caf106
@sgschantz
fix(ios): return persisted height from constraintTargetHeight
fe6c818
@sgschantz
fix(ios): try alternate image loading method
e989c57
@sgschantz
fix(ios): use engine bundle to find image
b9aae00
@srl295
feat(core): get_key_list needs to include all keys
2e5b601 
Fixes: #12298
@srl295
feat(core): test improvements for get_key_list()
6d1035a 
- move kmxplus processing into the base LdmlTestSource class
- add a function to traverse the layer list looking for keys to add
- The @@keyList keyword only has one example from each modifier set

Fixes: #12298
@sgschantz
fix(ios): added new blank keyboard assets to keyman engine
607c5cc
@sgschantz
fix(ios): use engine bundle -- not Keyman.bundle in engine
fbfb7f3
@sgschantz
fix(ios): add strings to bundle for localization
625eed5
@srl295
feat(core): test improvements for get_key_list()
f9862c3 
- just compare the key list to the key2.kmap table
- check the keylist for all LdmlTestSource instances - no syntax needed

Fixes: #12298
@srl295
Merge branch 'master' into fix/core/12298-get-key-list
3904d78
@sgschantz
fix(ios): fix rotation and resize animations
c3c8e0b
@markcsinclair
chore(common/web): add initial removeExtension test cases
bf7f4c2
@sgschantz
fix(ios): attempt to reload in-app keyboard on keyboard height change
221ba7b
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S18 milestone Dec 24, 2024
@srl295 srl295 self-assigned this Dec 24, 2024
@srl295 srl295 marked this pull request as ready for review December 26, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rc-swag rc-swag Awaiting requested review from rc-swag rc-swag is a code owner

@ermshiperete ermshiperete Awaiting requested review from ermshiperete ermshiperete is a code owner

@mcdurdin mcdurdin Awaiting requested review from mcdurdin mcdurdin is a code owner

@jahorton jahorton Awaiting requested review from jahorton jahorton is a code owner

@sgschantz sgschantz Awaiting requested review from sgschantz sgschantz is a code owner

@SabineSIL SabineSIL Awaiting requested review from SabineSIL SabineSIL is a code owner

@darcywong00 darcywong00 Awaiting requested review from darcywong00 darcywong00 is a code owner

@markcsinclair markcsinclair Awaiting requested review from markcsinclair markcsinclair is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@srl295 srl295

Labels
android/app/ android/engine/ android/ chore common/resources/ Build infrastructure common/web/ common/ core/ Keyman Core developer/compilers/ developer/ epic-ldml-editor ios/engine/ ios/ linux/config/ linux/engine/ linux/ mac/ windows/config/ windows/engine/ windows/
Projects
Keyman
Status: No status
Milestone
A18S18
Development

Successfully merging this pull request may close these issues.
7 participants
@srl295 @mcdurdin @sgschantz @markcsinclair @ermshiperete @keyman-server @darcywong00