fix(windows): bool return value of KeymanIsTextSelected #12841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12649
Note: there was a comment here about adding a new api function. Which we could do but if we did that we would need to update the TIPProcessKey so an new API call. As noted here
If we going to have to make a new version of
TIPProcessKey
it would probably better to just add a new argument function pointer to TIPProcessKey, which is IsTextSelected function and keepTIPGetContext
the same.User Testing
TEST_DELETE_SELECTED_TEXT
Install the Keyman for Windows build artifact with this PR.
This test must be done with an application using the Text Services Framework (TSF). You cannot use
the Web version of Word. Use WordPad that comes installed with Windows 10 and Windows 11.
Install a Keyman keyboard like EuroLatin
mySchool
School
and type backspaceExpected result
my
Some regression tests.
TEST_BACKSPACE_NO_SELECTION
Install a Keyman keyboard like euro_latin
mySchool
Expected result
mySchoo
TEST_SELECTION_TYPE_CHAR
mySchool
School
and type tExpected result
myt