Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): bool return value of KeymanIsTextSelected #12841

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rc-swag
Copy link
Contributor

@rc-swag rc-swag commented Dec 19, 2024

Fixes: #12649

Note: there was a comment here about adding a new api function. Which we could do but if we did that we would need to update the TIPProcessKey so an new API call. As noted here
If we going to have to make a new version of TIPProcessKey it would probably better to just add a new argument function pointer to TIPProcessKey, which is IsTextSelected function and keep TIPGetContext the same.

User Testing

TEST_DELETE_SELECTED_TEXT

Install the Keyman for Windows build artifact with this PR.
This test must be done with an application using the Text Services Framework (TSF). You cannot use
the Web version of Word. Use WordPad that comes installed with Windows 10 and Windows 11.

Install a Keyman keyboard like EuroLatin

  1. Select the EuroLatin Keyboard
  2. Open MS Word or WordPad
  3. Type mySchool
  4. Select School and type backspace

Expected result
my

Some regression tests.

TEST_BACKSPACE_NO_SELECTION

Install a Keyman keyboard like euro_latin

  1. Select the EuroLatin Keyboard
  2. Open MS Word or WordPad
  3. Type mySchool
  4. With the cursor still to the right of 'l' type backspace

Expected result
mySchoo

TEST_SELECTION_TYPE_CHAR

  1. Select the EuroLatin Keyboard
  2. Open MS Word or WordPad
  3. Type mySchool
  4. Select School and type t

Expected result
myt

@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Dec 19, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Dec 19, 2024

User Test Results

Test specification and instructions

  • TEST_DELETE_SELECTED_TEXT (OPEN)
  • TEST_BACKSPACE_NO_SELECTION (OPEN)
  • TEST_SELECTION_TYPE_CHAR (OPEN)
Results Template
# Test Results

* **TEST_DELETE_SELECTED_TEXT (OPEN):** notes
* **TEST_BACKSPACE_NO_SELECTION (OPEN):** notes
* **TEST_SELECTION_TYPE_CHAR (OPEN):** notes

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S17 milestone Dec 19, 2024
@rc-swag rc-swag self-assigned this Dec 19, 2024
@darcywong00 darcywong00 modified the milestones: A18S17, A18S18 Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

bug(windows): change return value of CKeymanEditSession::KeymanIsTextSelected to BOOL
2 participants