Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(windows): add right modifier included in hotkey optional functionality #12259

Merged
merged 7 commits into from
Sep 6, 2024
Merged

feat(windows): add right modifier included in hotkey optional functionality #12259

merged 7 commits into from
Sep 6, 2024

Conversation

rc-swag
Copy link
Contributor

@rc-swag rc-swag commented Aug 22, 2024 •
edited
Loading

Step 2. of Fixes:#11471

User Testing

TEST_LANGUAGE_HOTKEYS_LEFT_SIDE

For this test only the left and right modifier keys will trigger the hotkeys

  1. Install Keyman
  2. Install some keyboard layouts Tamil and IPA SIL
  3. Open Configuration and assign hotkeys to Ctrl+G to Tamil and
    Ctrl+Shift+Ito IPA SIL
  4. Open Notepad and type some text
  5. Switch to Tamil using the Hotkey press Left Ctrl+G
  6. Verify that it has switched in the task and language bar to Tamil and type some text.
  7. Switch to IPA SIL using the Hotkey press Left Ctrl+Left Shift+I
  8. Verify it has it has switched in the task and language bar to IPA SIL and type some text.

TEST_LANGUAGE_HOTKEYS_RIGHT_SIDE

For this test only the left and right modifier keys will trigger the hotkeys

  1. Install Keyman
  2. Install some keyboard layouts Tamil and IPA SIL
  3. Open Configuration and assign hotkeys to Ctrl+G to Tamil and
    Ctrl+Shift+Ito IPA SIL
  4. In Configuration Options tab click the check box for "Use right modifier for hotkeys"
  5. Open Notepad and type some text
  6. Switch to Tamil using the Hotkey press Right Ctrl+G
  7. Verify that it has switched in the task and language bar to Tamil and type some text.
  8. Switch to IPA SIL using the Hotkey press Ctrl+Right Shift+I
  9. Verify it has it has switched in the task and language bar to IPA SIL and type some text.

rc-swag added 2 commits August 22, 2024 16:32
@rc-swag
feat(windows): add right modifier included in HotKey
f1d9f53
@rc-swag
chore(windows): Merge branch 'master' into feat/windows/11471/right-m…
b0ff713 
…odifier-hk

# Keyman Conventional Commit suggestions:
#
# - Link to a Sentry issue with git trailer:
#     Fixes: _MODULE_-_ID_
# - Give credit to co-authors:
#     Co-authored-by: _Name_ <_email_>
# - Use imperative, present tense ('attach' not 'attaches', 'attached' etc)
# - Don't include a period at the end of the title
# - Always include a blank line before trailers
# - More: https://github.com/keymanapp/keyman/wiki/Pull-Request-and-Commit-workflow-notes
@rc-swag rc-swag self-assigned this Aug 22, 2024
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Aug 22, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Aug 22, 2024 •
edited
Loading

User Test Results

Test specification and instructions

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S9 milestone Aug 22, 2024
@rc-swag rc-swag mentioned this pull request Aug 27, 2024
Merged
@rc-swag rc-swag changed the base branch from master to feat/windows/11471/remove-old-flags-modifier August 29, 2024 11:23
@rc-swag rc-swag marked this pull request as ready for review August 29, 2024 11:38
@darcywong00 darcywong00 modified the milestones: A18S9, A18S10 Aug 31, 2024
@rc-swag
chore(windows): Merge branch 'feat/windows/11471/remove-old-flags-mod…
d70ad35 
…ifier' into feat/windows/11471/right-modifier-hk
Base automatically changed from feat/windows/11471/remove-old-flags-modifier to master September 2, 2024 02:59
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed and removed user-test-missing User tests have not yet been defined for the PR labels Sep 2, 2024
@dinakaranr
Copy link

dinakaranr commented Sep 2, 2024 •
edited
Loading

Test Results

I tested this issue with the attached "Keyman 18.0.95-alpha-test-12259" build on the Windows 10 OS. Here is my observation.

  • TEST_LANGUAGE_HOTKEYS_LEFT_SIDE (Passed):
  1. Installed the "Keyman-18.0.95.exe" file and gave all permissions to the application.
  2. Open the Keyman configuration dialog by pressing the icon from Windows tray.
  3. Installed the Tamil99 and IPA SIL keyboards.
  4. Navigate to the "HotKeys" tab. Here, I assigned the left side of CTRL+G to Tamil and CTRL_Shift+I to IPA SIL.
  5. Open the notepad. Press the left side of CTRL+G and then Enter some letters.
  6. Here, Verified that the Tamil letters appeared
  7. Press the Left side of the Ctrl+Shift+I key and then Enter some letters.
    Here, Verified that the keyboard switched from Tamil to IPA keyboard using the hotkeys.
    Verified that the IPA letters appeared.
    It works well.
  • TEST_LANGUAGE_HOTKEYS_RIGHT_SIDE (Passed):
  1. Installed the "Keyman-18.0.95.exe" file and gave all permissions to the application.
  2. Open the Keyman configuration dialog by pressing the icon from the Windows tray.
  3. Installed the Tamil99 and IPA SIL keyboards.
  4. Navigate to the "HotKeys" tab. Here, I assigned the right side of CTRL+G to Tamil and CTRL_Shift+I to IPA SIL.
  5. Open the notepad. Press the right side of CTRL+G and then Enter some letters.
  6. Here, Verified that the Tamil letters appeared.
  7. Press the right side of the Ctrl+Shift+I key and then Enter some letters.
  8. Here, Verified that the keyboard switched from Tamil to IPA keyboard using the hotkeys.
    Verified that the IPA letters appeared.
    It works well. Thank you.
    Please refer to the screenshot below

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Sep 2, 2024
ermshiperete
ermshiperete approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@ermshiperete ermshiperete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

common/windows/cpp/include/registry.h
@@ -110,7 +110,7 @@
#define REGSZ_KeyboardHotkeysAreToggle "hotkeys are toggles"
#define REGSZ_DeadkeyConversionMode "deadkey conversion mode" // CU // I4552
#define REGSZ_ZapVirtualKeyCode "zap virtual key code" // LM, defaults to 0x0E (_VK_PREFIX_DEFAULT)
/* Non-chiral use of hotkeys instead of left-only hotkeys */
/* Default is to only use left modifier in hotkeys trigger */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This comment is much clearer now

@rc-swag rc-swag merged commit e41a8cb into master Sep 6, 2024
10 checks passed
@rc-swag rc-swag deleted the feat/windows/11471/right-modifier-hk branch September 6, 2024 03:40
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.106-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ermshiperete ermshiperete ermshiperete approved these changes

@mcdurdin mcdurdin Awaiting requested review from mcdurdin mcdurdin is a code owner

Assignees

@rc-swag rc-swag

Labels
common/ feat has-user-test windows/config/ windows/engine/ windows/
Projects
Keyman
Archived in project
Milestone
A18S10
Development

Successfully merging this pull request may close these issues.
5 participants
@rc-swag @dinakaranr @keyman-server @ermshiperete @darcywong00