fix(windows): check IM window will be in a visible location #11967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IM display call back is used to show the IM window. With this change deadcode is removed and a check is made to ensure the IM window is completley visible coordinates for the monitor that has focus. If not it will be position close to where the caret in the application that has focus.
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions Test Artifacts |
ermshiperete
approved these changes
Aug 1, 2024
Co-authored-by: Eberhard Beilharz <[email protected]>
ermshiperete
approved these changes
Aug 2, 2024
…lidated-im-visibility
keymanapp-test-bot
bot
added
has-user-test
user-test-required
Test ResultsI tested this issue with the attached "Keyman 18.0.99-alpha-test-11967" build on the Windows 10 OS. I'm sharing my observation here.
I already had a two-monitor system hence, the display monitor was "extend these displays" mode. |
keymanapp-test-bot
bot
removed
the
user-test-required
|
Changes in this pull request will be available for download in Keyman version 18.0.100-alpha |
|
Do we need to cherry-pick this to stable-17.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IM display call back is used to show the IM window. With this change deadcode is removed and a check is made to ensure the IM window has completley visible coordinates for the monitor that has focus. If not and only if not it will be position close to where the caret in the application that has focus.
USER Testing
TEST_IMX_VISIBLE
To do this test, you need two monitors.
Install the Keyman for Windows Build with this PR
Install the Simplified Chinese cs_pinyin keyboard
Open Notepad
Type hanzi
Ensure the IM pop-up appears and is visible
In the Windows settings for monitors if it is not already set primary monitor to be on the right of the second monitor. In Windows 10 this is the setting
Go to Notepad and again type
Insure the IMX is still visible