chore(core): dx better err message on embedded test vkeys 🙀 #11119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
…tter-embedded-test-msg
srl295
changed the title
- report on vk-not-found - separate message for excess string
mcdurdin
approved these changes
Mar 29, 2024
srl295
force-pushed
the
feat/core/11072-default-modifier
branch
from
b5c22e8 to
bca037c
Compare
srl295
requested review from
ermshiperete,
jahorton and
darcywong00
as code owners
srl295
force-pushed
the
chore/core/dx-better-embedded-test-msg
branch
from
61176e9 to
054d9fd
Compare
…tter-embedded-test-msg
|
force pushes due to error in #11118 - just cleaning up the parent branch |
…tter-embedded-test-msg
ermshiperete
approved these changes
Apr 2, 2024
|
Changes in this pull request will be available for download in Keyman version 17.0.301-beta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given:
produces err:
.. instead of an uninformative assert.
Also if you have
[SHIFT K_BKQUOTE K_BKQUOTE]it will produce@keymanapp-test-bot skip