Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds integration test for compound responsive prop #142

Closed
wants to merge 2 commits into from
Closed

Adds integration test for compound responsive prop #142

wants to merge 2 commits into from

Conversation

kettanaito
Copy link
Owner

@kettanaito kettanaito commented Apr 6, 2019 •
edited
Loading

Change log

  • Adds missing integration test for compound responsive prop
  • Removes blocking rules from tslint
  • Removes calls to resetLayout in responsive props integration tests

GitHub issues

@kettanaito
Copy link
Owner Author

kettanaito commented Apr 6, 2019 •
edited
Loading

Integration tests will fail until #119 is fixed.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.588% when pulling 6403e39 on 119-compound-responsive-prop into 01bb6f5 on master.

@kettanaito
Copy link
Owner Author

Need to assess whether the effort of resolving the merge conflicts is worth reviving this branch.

@kettanaito kettanaito closed this Jul 12, 2019
@kettanaito kettanaito deleted the 119-compound-responsive-prop branch May 27, 2020 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prop with explicit "down" behavior overrides implicit "up" behavior of preceding prop
2 participants
@kettanaito @coveralls