Skip to content

Commit

Permalink
Adds "yarn verify" command
Browse files Browse the repository at this point in the history
  • Loading branch information
kettanaito committed Dec 6, 2019
1 parent 7c844cf commit 8a463ce
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -222,13 +222,13 @@ Verify your newly created E2E test by [Running E2E tests](#running-e2e-tests) an

### Verifying changes

There is a shorthand command to verify your introduced changes:
There is a shorthand command to verify your newly introduced changes on local:

```bash
$ yarn ci
$ yarn verify
```

> This is going to build the library, Storybook, and run unit and E2E tests. It's **recommended you perform this command** before creating a Pull request.
> This is going to build and test all the packages. This command can also be run in a package's directory to verify that respective package.
## Afterword

Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
"lint": "lerna exec yarn lint",
"clean": "lerna exec yarn clean",
"build": "lerna exec yarn build",
"test": "lerna exec yarn test"
"test": "lerna exec yarn test",
"verify": "lerna exec yarn verify"
},
"husky": {
"hooks": {
Expand Down
3 changes: 2 additions & 1 deletion packages/atomic-layout-core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
"test": "jest --runInBand",
"clean": "rimraf lib",
"build:types": "ttsc --skipLibCheck",
"build": "cross-env NODE_ENV=production rollup -c"
"build": "cross-env NODE_ENV=production rollup -c",
"verify": "yarn lint && yarn test && yarn build"
},
"devDependencies": {
"@types/jest": "24.0.23",
Expand Down
3 changes: 2 additions & 1 deletion packages/atomic-layout/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
"cypress:cli": "cypress run --spec=./examples/all.test.js --browser=chrome --env envName=ci",
"test": "yarn test:unit && yarn test:e2e",
"test:unit": "cross-env BABEL_ENV=test jest --runInBand",
"test:e2e": "yarn cypress:cli"
"test:e2e": "yarn cypress:cli",
"verify": "yarn lint && yarn build && yarn bundlesize && yarn test"
},
"bundlesize": [
{
Expand Down

0 comments on commit 8a463ce

Please sign in to comment.