Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue when using Model.compile multiple times #20602

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

james77777778
Copy link
Contributor

Fixes #20474 #20473

Credits to @TheMGGdev
I adopted the changes and added a test.

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (033d967) to head (b3e98ff).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20602      +/-   ##
==========================================
- Coverage   82.39%   82.38%   -0.01%     
==========================================
  Files         516      516              
  Lines       48436    48424      -12     
  Branches     7564     7560       -4     
==========================================
- Hits        39908    39895      -13     
- Misses       6705     6710       +5     
+ Partials     1823     1819       -4     
Flag Coverage Δ
keras 82.23% <ø> (-0.01%) ⬇️
keras-jax 65.36% <ø> (-0.02%) ⬇️
keras-numpy 60.30% <ø> (-0.02%) ⬇️
keras-tensorflow 66.25% <ø> (-0.02%) ⬇️
keras-torch 65.24% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Dec 6, 2024
@fchollet fchollet merged commit 1597013 into keras-team:master Dec 6, 2024
7 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Dec 6, 2024
@james77777778 james77777778 deleted the fix-multiple-compiles branch December 7, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

NO _loss_tracker on train_on_batch because compile model multiple times. Possible Bug.
4 participants