Modified example in depthwise_conv1d file #20268
Conversation
Example code has changed by modifying existing code
| @@ -92,7 +92,7 @@ class DepthwiseConv1D(BaseDepthwiseConv): | |||
| Example: | |||
|
|
|||
| >>> x = np.random.rand(4, 10, 12) | |||
| >>> y = keras.layers.DepthwiseConv1D(3, 3, 2, activation='relu')(x) | |||
| >>> y = keras.layers.DepthwiseConv1D(kernel_size=3, depth_multiplier=3, strides=2, activation='relu')(x) | |||
There was a problem hiding this comment.
This wouldn't work, it's lacking the filters argument
There was a problem hiding this comment.
Hi @fchollet ,
DepthwiseConv1D doesn't have filter arguments. If the filter argument is added then it's showing this error ValueError: Unrecognized keyword arguments passed to DepthwiseConv1D: {'filters': 16}
| @@ -92,7 +92,7 @@ class DepthwiseConv1D(BaseDepthwiseConv): | |||
| Example: | |||
|
|
|||
| >>> x = np.random.rand(4, 10, 12) | |||
| >>> y = keras.layers.DepthwiseConv1D(3, 3, 2, activation='relu')(x) | |||
| >>> y = keras.layers.DepthwiseConv1D(kernel_size=3, depth_multiplier=3, strides=2, activation='relu')(x) | |||
There was a problem hiding this comment.
This doesn't pass the linter, every line should be below 80 characters. See below:
./keras/src/layers/convolutional/depthwise_conv1d.py:95:81: E501 line too long (108 > 80 characters)
There was a problem hiding this comment.
Hi @ruidazeng,
Changed .Thank you for the suggestion !
Example code has changed by modifying existing code
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20268 +/- ##
==========================================
+ Coverage 78.89% 82.22% +3.32%
==========================================
Files 507 515 +8
Lines 48221 48165 -56
Branches 8877 7527 -1350
==========================================
+ Hits 38045 39603 +1558
+ Misses 8344 6744 -1600
+ Partials 1832 1818 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Example code has changed by modifying existing code