Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YOLOV8 instance segmentation model using YOLACT #2474

Merged
merged 12 commits into from
Sep 17, 2024

Conversation

oarriaga
Copy link
Contributor

What does this PR do?

Adds YOLACT fully convolutional instance segmentation model to YOLOV8.

Fixes # (issue)

#2007

Before submitting

  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
    YOLOv8 instance segmentation #2007
  • [ ] Did you write any new necessary tests?
  • [ ] If this adds a new model, can you run a few training steps on TPU in Colab to ensure that no XLA incompatible OP are used?

Who can review?

@divyashreepathihalli

Copy link
Collaborator

@divyashreepathihalli divyashreepathihalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! left som initial comments. Can we please add a yolo_v8_backbone file into the folder, even if it is just wrapping the original yolov8 model?

Also, please add a demo colab to verify outputs and numerics. A colob for weights conversion or training is also needed.

@oarriaga
Copy link
Contributor Author

oarriaga commented Sep 6, 2024

Hi @divyashreepathihalli where would you like me to add the colab?

@divyashreepathihalli
Copy link
Collaborator

Hi @divyashreepathihalli where would you like me to add the colab?

Please add a Colab link here is the comments, so that I can verify the output, it doesn't have to be a part of the code added in the PR.

@divyashreepathihalli
Copy link
Collaborator

can you please add the model folder path here -

keras_cv/src/models/stable_diffusion

to trigger the GPU tests. Thanks!

@oarriaga
Copy link
Contributor Author

Hi @divyashreepathihalli, here is a colab with a training instance.

@divyashreepathihalli divyashreepathihalli added the kokoro:force-run Runs Tests on GPU label Sep 12, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Sep 12, 2024
Copy link
Collaborator

@divyashreepathihalli divyashreepathihalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! a few small edits.

return x


# TODO(ianstenbit): Remove this method once we're using CSPDarkNet backbone
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove todo

# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
"""Label encoder for YOLOV8. This uses the TOOD Task Aligned Assigner approach.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move this to doc-string description block

@divyashreepathihalli divyashreepathihalli added the kokoro:force-run Runs Tests on GPU label Sep 17, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Sep 17, 2024
@divyashreepathihalli divyashreepathihalli merged commit 4e0855f into keras-team:master Sep 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants