-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add YOLOV8 instance segmentation model using YOLACT #2474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! left som initial comments. Can we please add a yolo_v8_backbone file into the folder, even if it is just wrapping the original yolov8 model?
Also, please add a demo colab to verify outputs and numerics. A colob for weights conversion or training is also needed.
keras_cv/src/models/segmentation/yolo_v8_segmentation/yolo_v8_segmentation.py
Outdated
Show resolved
Hide resolved
keras_cv/src/models/segmentation/yolo_v8_segmentation/yolo_v8_segmentation.py
Outdated
Show resolved
Hide resolved
keras_cv/src/models/segmentation/yolo_v8_segmentation/yolo_v8_segmentation.py
Show resolved
Hide resolved
keras_cv/src/models/segmentation/yolo_v8_segmentation/yolo_v8_segmentation.py
Show resolved
Hide resolved
Hi @divyashreepathihalli where would you like me to add the colab? |
Please add a Colab link here is the comments, so that I can verify the output, it doesn't have to be a part of the code added in the PR. |
can you please add the model folder path here -
to trigger the GPU tests. Thanks! |
Hi @divyashreepathihalli, here is a colab with a training instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! a few small edits.
return x | ||
|
||
|
||
# TODO(ianstenbit): Remove this method once we're using CSPDarkNet backbone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove todo
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
"""Label encoder for YOLOV8. This uses the TOOD Task Aligned Assigner approach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move this to doc-string description block
What does this PR do?
Adds YOLACT fully convolutional instance segmentation model to YOLOV8.
Fixes # (issue)
#2007
Before submitting
Pull Request section?
to it if that's the case.
YOLOv8 instance segmentation #2007
Who can review?
@divyashreepathihalli