Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Faster R-CNN to Keras3 #2458

Merged
merged 46 commits into from
Aug 20, 2024

Conversation

sineeli
Copy link
Contributor

@sineeli sineeli commented Jun 25, 2024

What does this PR do?

Port legacy Faster R-CNN to Keras 3

Fix minor bug in ROI Align, make sure to build the shapes for each layer components.

The present PR is modified code of Updating FasterRCNN to use Task API contributed by @ariG23498. Please @ariG23498 any suggestions form your side are appreciated.

@sineeli
Copy link
Contributor Author

sineeli commented Jun 25, 2024

Can we make last dimension of the roi_generator.py boxes output have fixed 4 as dimension, any suggestion on how to make it possible ?

Ref:
image

@sineeli
Copy link
Contributor Author

sineeli commented Jun 25, 2024

@VarunS1997 Review for any corrections are fixes required from based code.

Thanks!

@ariG23498
Copy link
Contributor

ariG23498 commented Jun 25, 2024

Hey @sineeli this is so cool! Thanks for taking this up. It was a long time ago and unfortunately I would not be able to give you a thorough review.

What I understand should be green flags are:

  • The model should follow the Functional API of Keras
  • It should use the model.fit() API and train on PASCAL VOC

Last I worked on it I could not get every component to comply with the Functional API. If you got that part sorted, you are good to go ^_^

Closes #2012

@sineeli
Copy link
Contributor Author

sineeli commented Jun 25, 2024

Hey @sineeli this is so cool! Thanks for taking this up. It was a long time ago and unfortunately I would not be able to give you a thorough review.

What I understand should be green flags are:

  • The model should follow the Functional API of Keras
  • It should use the model.fit() API and train on PASCAL VOC

Last I worked on it I could not get every component to comply with the Functional API. If you got that part sorted, you are good to go ^_^

Closes #2012

Yes trying to make it functional, hopefully it will workout!

@chunduriv chunduriv requested a review from VarunS1997 June 26, 2024 17:17
@chunduriv chunduriv added the wip working in progress from KerasCV team label Jun 26, 2024
Copy link
Collaborator

@VarunS1997 VarunS1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, good ideas here and good implementation.

We should definitely, however, implement some of the requested changes.

Also please remember to run keras_cv's linter included under the shell/ directory.

I also will have to come back to this for architecture verification. But, if you have a working colab or similar, that would work as well.

@sineeli sineeli requested a review from VarunS1997 July 23, 2024 18:51
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Aug 16, 2024
- Fix ROI Align ops for torch backend
@sachinprasadhs sachinprasadhs added the kokoro:force-run Runs Tests on GPU label Aug 16, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Aug 16, 2024
@sachinprasadhs sachinprasadhs added the kokoro:force-run Runs Tests on GPU label Aug 16, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Aug 16, 2024
@sachinprasadhs sachinprasadhs added the kokoro:force-run Runs Tests on GPU label Aug 16, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Aug 16, 2024
Copy link
Collaborator

@divyashreepathihalli divyashreepathihalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments to reduce tests sizes.

- Add build method for fpn
@sachinprasadhs sachinprasadhs added the kokoro:force-run Runs Tests on GPU label Aug 19, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Aug 19, 2024
@sachinprasadhs sachinprasadhs added the kokoro:force-run Runs Tests on GPU label Aug 20, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Aug 20, 2024
- Correct YOLOv8 preset test case
@sachinprasadhs sachinprasadhs added the kokoro:force-run Runs Tests on GPU label Aug 20, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Aug 20, 2024
@sachinprasadhs sachinprasadhs added the kokoro:force-run Runs Tests on GPU label Aug 20, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Aug 20, 2024
@divyashreepathihalli
Copy link
Collaborator

Excellent work!! Thanks Siva!!

@divyashreepathihalli divyashreepathihalli dismissed VarunS1997’s stale review August 20, 2024 21:43

FasterRCNN has been handed off to Divya.

@divyashreepathihalli divyashreepathihalli merged commit 2f9eb86 into keras-team:master Aug 20, 2024
10 checks passed
@sineeli sineeli deleted the sineeli/faster-rcnn branch August 23, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants