add raise for sparql exceptions #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galtay
reviewed
Oct 30, 2023
| ).json() | ||
| ) | ||
| if resp.status_code != 200: | ||
| raise SPARQLResponseNotOk( |
There was a problem hiding this comment.
I think I'd probably prefer the caller to use a try/except or maybe something like this here (https://docs.python-requests.org/en/latest/user/quickstart/#response-status-codes) ... what do you thing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to take or leave this, I implemented it on my fork due to rate limiting issues when using the SPARQL service alot.
Happy to follow up with any feedback to make it more idiomatic w.r.t your code base for error handling (or feel free to change it yourself!).