LSP: Implementing hover hints #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within the typechecker, collect identifier information (if a flag is set) into the TypedModule currently being typechecked. From within the LanguageService, this metadata can be used to find the identifier being hovered over and display some information about that identifier (name, type/signature, import module (if imported), etc). Eventually there will be more functionality here, like displaying fields, methods, enum variants, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the typechecker, collect identifier information (if a flag is set) into the TypedModule currently being typechecked. From within the LanguageService, this metadata can be used to find the identifier being hovered over and display some information about that identifier (name, type/signature, import module (if imported), etc). Eventually there will be more functionality here, like displaying fields, methods, enum variants, etc.
Examples
Hovering over a variable
Hovering over a loop iteratee
Hovering over a standalone function (methods not yet implemented)
Hovering over type (with "imported from ..." message)
