Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permission expiry timezones #456

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Permission expiry timezones #456

merged 2 commits into from
Dec 18, 2024

Conversation

SugaryLump
Copy link

  • Expiry dates are now stores as the last second of the specified date, forcing UTC to ignore client's timezone
  • When querying for permission expiry dates, the dates are considered to be in a configured timezone or UTC by default
    • e.g., admin selects 17/12/2024 in UI -> Solr stores expiry as 17/12/2024T23:59:59Z; user tries to access that database -> query checks if the current time in the configured timezone is after 17/12/2024T23:59:59Z

@SugaryLump SugaryLump marked this pull request as ready for review December 18, 2024 09:25
@SugaryLump SugaryLump marked this pull request as draft December 18, 2024 09:27
@SugaryLump SugaryLump marked this pull request as ready for review December 18, 2024 10:33
@006627 006627 merged commit 6e1d2b2 into development Dec 18, 2024
2 checks passed
@SugaryLump SugaryLump deleted the aflores-dev-expiry_timezones branch December 18, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@006627 006627 006627 approved these changes

Assignees

@006627 006627

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SugaryLump @006627