Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change drag/drop between databases to default to COPY #11338

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

leroivi
Copy link
Contributor

@leroivi leroivi commented Oct 9, 2024

Fixes #172
This changes makes the drop action from one database to another as a copy action, but inside the same database still a move action. As suggested by @NicoHood, this behavior is similar to file system managers with USB keys, and it is safer as it does not remove any data from a database.

Testing strategy

  • Create 2 testing databases
  • Fill the first with a group, an inner group, and a password entry to each levels
  • Drag an entry to the root of the second database
  • Verify it's present in both databases
  • Drag a group to the root of the second database
  • Verify it's present in both databases
  • Drag a password from a group to another
  • Verify it has been moved
  • Drag a group from a group to another
  • Verify it has been moved
  • Drag a password from a group to another with Control pushed
  • Verify it has been copied
  • Drag a password from a database to another with Shift pushed
  • Verify it has been moved

Type of change

  • ✅ New feature (change that adds functionality)
  • ✅ Breaking change (causes existing functionality to change)

@droidmonkey

This comment was marked as outdated.

@droidmonkey droidmonkey reopened this Oct 13, 2024
@droidmonkey droidmonkey added the ux label Oct 13, 2024
@droidmonkey droidmonkey added this to the v2.8.0 milestone Oct 13, 2024
@droidmonkey droidmonkey self-requested a review October 13, 2024 13:42
@droidmonkey droidmonkey changed the title Fix Issue #172 copy when drop in a different database Change drag/drop between databases to default to COPY Oct 13, 2024
@droidmonkey droidmonkey force-pushed the issue_172_copy_on_drop branch from 1f2f422 to 49a2849 Compare October 13, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Copy/Paste of entries and groups between open databases
2 participants