Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Proton Pass importer #11197

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

droidmonkey
Copy link
Member

@droidmonkey droidmonkey commented Aug 25, 2024

We will only support unencrypted json exports since Proton Pass uses PGP for encrypted exports for some reason.
We also do not support passkey exports from Proton Pass yet.

Screenshots

image

Testing strategy

Added unit tests

Type of change

  • ✅ New feature (change that adds functionality)

@droidmonkey droidmonkey added this to the v2.7.10 milestone Aug 25, 2024
@droidmonkey droidmonkey requested a review from phoerious August 25, 2024 20:11
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 81.42857% with 26 lines in your changes missing coverage. Please review.

Project coverage is 63.97%. Comparing base (0cb0373) to head (5cd9d73).

Files with missing lines Patch % Lines
src/gui/wizard/ImportWizardPageReview.cpp 33.33% 12 Missing ⚠️
src/format/ProtonPassReader.cpp 90.99% 10 Missing ⚠️
src/gui/DatabaseTabWidget.cpp 0.00% 2 Missing ⚠️
src/gui/wizard/ImportWizardPageSelect.cpp 71.43% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11197      +/-   ##
===========================================
+ Coverage    63.88%   63.97%   +0.09%     
===========================================
  Files          362      364       +2     
  Lines        38147    38277     +130     
===========================================
+ Hits         24367    24486     +119     
- Misses       13780    13791      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@droidmonkey droidmonkey force-pushed the feature/protonpass-importer branch from d909d9e to cb60486 Compare August 31, 2024 04:00
@droidmonkey droidmonkey force-pushed the feature/protonpass-importer branch from cb60486 to 6bbf9d1 Compare September 27, 2024 23:45
@keepassxreboot keepassxreboot deleted a comment from gburkhow Oct 7, 2024
@keepassxreboot keepassxreboot deleted a comment from gburkhow Oct 7, 2024
@droidmonkey droidmonkey force-pushed the feature/protonpass-importer branch from 6bbf9d1 to 40f5c75 Compare October 8, 2024 03:38
@phoerious phoerious added pr: new feature Pull request that adds a new feature and removed new feature labels Nov 22, 2024
@droidmonkey droidmonkey force-pushed the feature/protonpass-importer branch 3 times, most recently from 9704699 to 6dd6ce5 Compare December 2, 2024 05:08
@droidmonkey droidmonkey force-pushed the feature/protonpass-importer branch from 6dd6ce5 to 5cd9d73 Compare December 23, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new feature Pull request that adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Proton Pass importer
2 participants