Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip retry for registered wallets #816

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Skip retry for registered wallets #816

wants to merge 2 commits into from

Conversation

ptdatta
Copy link
Contributor

@ptdatta ptdatta commented Jun 24, 2024

Fixes #815

The backoffRetrier runs retry for every error which makes the redemption process takes a long time.

So for registered wallets, it should not retry so instead of retryAll we use skipRetryWhenMatched["Wallet with the given ID has not been registered"] so that it skips retry for registered wallets.

@ptdatta ptdatta mentioned this pull request Jun 24, 2024
Open
@mhluongo mhluongo requested a review from nkuba August 23, 2024 15:21
@mhluongo
Copy link
Member

Thanks for this @ptdatta! Giving it a look

@mhluongo mhluongo requested a review from Shadowfiend August 23, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkuba nkuba Awaiting requested review from nkuba

@Shadowfiend Shadowfiend Awaiting requested review from Shadowfiend

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve wallet lookup during redemptions
2 participants
@ptdatta @mhluongo