Replaced bcoin with bitcoinjs-lib for redemptions #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasz-zimnoch
approved these changes
Oct 3, 2023
| @@ -242,6 +256,7 @@ async function getWalletRedemptionRequests( | |||
| * - there is at least one redemption | |||
| * - the `requestedAmount` in each redemption request is greater than | |||
| * the sum of its `txFee` and `treasuryFee` | |||
| * @param bitcoinNetwork - The target Bitcoin network (mainnet or testnet). | |||
There was a problem hiding this comment.
Same comment as in #702 (comment) but non-blocking and we can address it there.
There was a problem hiding this comment.
Done in e202330.
lukasz-zimnoch
added a commit
that referenced
this pull request
Oct 10, 2023
Here we pull changes from #703
lukasz-zimnoch
added a commit
that referenced
this pull request
Oct 10, 2023
Here we pull changes from #703
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #695.
This PR replaces the bcoin library with bitcoinjs-lib for redemptions.