Add TLS and basic authentication in web interface #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) TLS and basic authentication are in flag `--web.config.file`: https://github.com/prometheus/exporter-toolkit/blob/master/docs/web-configuration.md#web-configuration 2) Config file has two dashes now: `--config-file` 3) Web address and port are in flag `--web.listen-address`. Environment variables `PUBLISH_PORT` and `PUBLISH_ADDR` are not used now. Config options "publish_port" and "publish_addr" were removed from "config-file". 4) Log levels "fatal" and "panic" are not used anymore. Example: ./rabbitmq_exporter --config-file config.example.json --web.config.file web_config.yml --web.listen-address 127.0.0.1:9419 Prometheus Exporter Toolkit provides TLS and basic authentication in exporters. The exporter requires newer command-line and log packages. So packages "flag" and "logrus" were replaced. Also package "io/ioutil" is outdated and was removed from exporter. kbudde#412
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--web.config.file: https://github.com/prometheus/exporter-toolkit/blob/master/docs/web-configuration.md#web-configuration 2) Config file has two dashes now:--config-file--web.listen-address. Environment variablesPUBLISH_PORTandPUBLISH_ADDRare not used now.Config options "publish_port" and "publish_addr" were removed from "config-file".
Example:
./rabbitmq_exporter --config-file config.example.json --web.config.file web_config.yml --web.listen-address 127.0.0.1:9419
Prometheus Exporter Toolkit provides TLS and basic authentication in exporters.
The exporter requires newer command-line and log packages. So packages "flag" and "logrus" were replaced.
Also package "io/ioutil" is outdated and was removed from exporter.
#412