Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logic to sort path #336

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Change logic to sort path #336

merged 1 commit into from
Dec 26, 2024

Conversation

kayjan
Copy link
Owner

@kayjan kayjan commented Dec 26, 2024

Description

Github tests work differently from local testing

Testing

Additional notes

Checklist

I have read through the contributing guidelines and ensured that

  • I have added a descriptive title for this pull request.
  • I have followed the convention and standards, and my code is checked for style and correctness.
  • I have added test cases, and unit tests pass with 100% code coverage.
  • I have updated the documentation and code docstrings.

Checklist (for reviewer)

  • I have added label (breaking / enhancement / bug / documentation) to this pull request, if applicable.
  • I will ensure this change is captured in the CHANGELOG.md file.

@kayjan kayjan added the enhancement New feature or request label Dec 26, 2024
Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Complexity Health
bigtree 100% 100% 0
bigtree.binarytree 100% 100% 0
bigtree.dag 100% 100% 0
bigtree.node 100% 100% 0
bigtree.tree 100% 100% 0
bigtree.utils 100% 100% 0
Summary 100% (2421 / 2421) 100% (1018 / 1018) 0

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 738e85c Previous: 35cb5d6 Ratio
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 14971.830500877339 iter/sec (stddev: 0.000016458900283851612) 14231.472046493911 iter/sec (stddev: 0.00002020090936799969) 0.95
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 683.075203199485 iter/sec (stddev: 0.000002298874856355714) 682.8079041161111 iter/sec (stddev: 0.0000339997446489116) 1.00
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 11.832720162957878 iter/sec (stddev: 0.0026569777719402735) 11.855436373775948 iter/sec (stddev: 0.003021004403910958) 1.00
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 67.43842571631521 iter/sec (stddev: 0.0035201751223819526) 67.68291823890107 iter/sec (stddev: 0.003444149617564158) 1.00
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions 23122.08228312741 iter/sec (stddev: 0.000005439348202471317) 22934.228074327933 iter/sec (stddev: 0.000008722939962892127) 0.99
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions 1789.1576153907627 iter/sec (stddev: 0.000011473019657732148) 1793.2817746930687 iter/sec (stddev: 0.000005429377997790168) 1.00
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions 123.56081994392758 iter/sec (stddev: 0.003016532307074865) 122.92872852316702 iter/sec (stddev: 0.0032109684285456298) 0.99
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions 98.12197676378263 iter/sec (stddev: 0.002572724301905167) 91.65220280340681 iter/sec (stddev: 0.003188638632792475) 0.93

This comment was automatically generated by workflow using github-action-benchmark.

@kayjan kayjan merged commit ce55085 into master Dec 26, 2024
6 checks passed
@kayjan kayjan deleted the v0.23.0 branch December 26, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant