Tidy and add tests for modify module #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 415afb7 | Previous: 4459ff4 | Ratio |
|---|---|---|---|
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 |
14744.076014540557 iter/sec (stddev: 0.000015894982624666463) |
14808.836432609516 iter/sec (stddev: 0.000018276093998188393) |
1.00 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 |
688.4677791575135 iter/sec (stddev: 0.000015563420256424255) |
690.9404407618113 iter/sec (stddev: 0.000020024486224810658) |
1.00 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 |
11.850073013691683 iter/sec (stddev: 0.0025916774506448245) |
11.798482223307227 iter/sec (stddev: 0.0025368368649917607) |
1.00 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 |
67.03145227683117 iter/sec (stddev: 0.003500444297600789) |
68.32946067573548 iter/sec (stddev: 0.0032854353993074337) |
1.02 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions |
22566.46104898742 iter/sec (stddev: 0.000008927576667728774) |
22021.12045742032 iter/sec (stddev: 0.000002298167749013623) |
0.98 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions |
1766.1840745318093 iter/sec (stddev: 0.000014128134911286635) |
1687.8259561135467 iter/sec (stddev: 0.00006115391783906489) |
0.96 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions |
118.7648858052187 iter/sec (stddev: 0.0034249366777931926) |
119.16914462020154 iter/sec (stddev: 0.0034163613817203412) |
1.00 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions |
94.30026651423036 iter/sec (stddev: 0.002952354376374877) |
91.65405548871612 iter/sec (stddev: 0.0033109019914501357) |
0.97 |
This comment was automatically generated by workflow using github-action-benchmark.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
Additional notes
Checklist
I have read through the contributing guidelines and ensured that
Checklist (for reviewer)