Add aggregate param to tree_diff #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: adae847 | Previous: 9b7aec8 | Ratio |
|---|---|---|---|
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 |
14986.572031448575 iter/sec (stddev: 0.000013197440964749818) |
15481.385955558057 iter/sec (stddev: 0.00001881314160047979) |
1.03 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 |
650.4701126381592 iter/sec (stddev: 0.000010681767168929415) |
678.6289266187782 iter/sec (stddev: 0.0000495985202422962) |
1.04 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 |
11.75790480589083 iter/sec (stddev: 0.00306057805918262) |
12.382393335985086 iter/sec (stddev: 0.0030380286360646596) |
1.05 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 |
63.75880625075746 iter/sec (stddev: 0.004204092124546105) |
66.68127475579314 iter/sec (stddev: 0.0038063433580471555) |
1.05 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions |
21965.832148602392 iter/sec (stddev: 0.00000718356849899067) |
22904.181502704294 iter/sec (stddev: 0.000007981892057195312) |
1.04 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions |
1613.9097067555967 iter/sec (stddev: 0.000002901046991800009) |
1763.8608373774161 iter/sec (stddev: 0.00001514841928411277) |
1.09 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions |
115.72688700007456 iter/sec (stddev: 0.0033837878007410985) |
110.13654707079313 iter/sec (stddev: 0.0038186826542215943) |
0.95 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions |
88.43240396387718 iter/sec (stddev: 0.003969383372748652) |
91.5632629766412 iter/sec (stddev: 0.003616517855631073) |
1.04 |
This comment was automatically generated by workflow using github-action-benchmark.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aggregate will aggregate all the changes in tree_diff, only applies to move/shift and not new/removed changes
Testing
Additional notes
Checklist
I have read through the contributing guidelines and ensured that
Checklist (for reviewer)