Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tips and tricks for custom classes #320

Merged
merged 2 commits into from
Nov 4, 2024
Merged

More tips and tricks for custom classes #320

merged 2 commits into from
Nov 4, 2024

Conversation

kayjan
Copy link
Owner

@kayjan kayjan commented Nov 4, 2024

Description

Testing

Additional notes

Checklist

I have read through the contributing guidelines and ensured that

  • I have added a descriptive title for this pull request.
  • I have followed the convention and standards, and my code is checked for style and correctness.
  • I have added test cases, and unit tests pass with 100% code coverage.
  • I have updated the documentation and code docstrings.

Checklist (for reviewer)

  • I have added label (breaking / enhancement / bug / documentation) to this pull request, if applicable.
  • I will ensure this change is captured in the CHANGELOG.md file.

@kayjan kayjan added the documentation Improvements or additions to documentation label Nov 4, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: f1dd40b Previous: 4e85c7a Ratio
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 16041.837111197092 iter/sec (stddev: 0.0000034918347058692377) 15670.689855133034 iter/sec (stddev: 0.000005114079084348671) 0.98
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 677.5862170022724 iter/sec (stddev: 0.000012741144959029354) 679.0438478650734 iter/sec (stddev: 0.000013926963031220604) 1.00
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 12.268503702028172 iter/sec (stddev: 0.0026057268138597) 12.35080442082941 iter/sec (stddev: 0.0025299956068829664) 1.01
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 70.9637515063851 iter/sec (stddev: 0.002786713835064834) 69.98420050686502 iter/sec (stddev: 0.003226456824768121) 0.99
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions 11630.036896211912 iter/sec (stddev: 0.00006214712002319655) 9583.018890616639 iter/sec (stddev: 0.0000871901552076084) 0.82
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions 1681.3323684715335 iter/sec (stddev: 0.0000020692772848510233) 1651.8226996319438 iter/sec (stddev: 0.000008656896190596417) 0.98
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions 112.85662057282833 iter/sec (stddev: 0.003785683536375868) 117.68916177501205 iter/sec (stddev: 0.0032048902800759314) 1.04
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions 93.50149639796369 iter/sec (stddev: 0.003315158420721725) 94.74622786606413 iter/sec (stddev: 0.003079124904367879) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@kayjan kayjan enabled auto-merge November 4, 2024 15:01
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
bigtree 100% 100% 0
bigtree.binarytree 100% 100% 0
bigtree.dag 100% 100% 0
bigtree.node 100% 100% 0
bigtree.tree 100% 100% 0
bigtree.utils 100% 100% 0
Summary 100% (2388 / 2388) 100% (1006 / 1006) 0

@kayjan kayjan merged commit d0dfa7c into master Nov 4, 2024
6 checks passed
@kayjan kayjan deleted the docs/more-tips branch November 4, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant