add security context, update the app version and image tag #93
Conversation
charts/geoserver/v0.3.4/README.md
Outdated
| @@ -0,0 +1,72 @@ | |||
| # GeoServer | |||
|
|
|||
| This is Kartoza's GeoServer Rancher charts | |||
There was a problem hiding this comment.
Is it for rancher or kubernetes?
|
|
||
| - Default TLS enabled | ||
| - Generate new datadir at startup if volume empty | ||
| - Some plugins are shipped |
There was a problem hiding this comment.
Default extensions are activated on startup
There was a problem hiding this comment.
Added that on readme.
I've added the environment variable. Could you please review to ensure everything looks correct? |
| {{- end }} | ||
| env: | ||
| {{- if .Values.enableJSONP }} | ||
| - name: ENABLE_JSONP |
There was a problem hiding this comment.
I'd like to know why only this env was chosen to be exposed. This defaults to true so we can skip it. We need to pass env that affects the image in some way
There was a problem hiding this comment.
I copied the deployment configuration from the previous Helm chart, which included exposing ENABLE_JSONP. While it defaults to true, we can consider disabling it if it's not necessary.
| {{- tpl . $ | nindent 10 }} | ||
| {{- end }} | ||
| {{- else }} | ||
| startupProbe: |
There was a problem hiding this comment.
Do you know if this probe happens internally or using the externally exposed geoserver? If it's the latter then this can be affected by env GEOSERVER_CONTEXT_ROOT
No description provided.